openstack/barbican
Code Issues Proposed changes

Merge "Fix barbican B105 issues"

Browse Source
This commit is contained in:
Zuul 2019-08-06 08:28:26 +00:00 committed by Gerrit Code Review
commit db7e9cbc65
5 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
barbican/cmd/barbican_manage.py
View File

@ -143,8 +143,8 @@ class DbCommands(object):
commands.current(verbose, sql_url=CONF.sql_connection) commands.current(verbose, sql_url=CONF.sql_connection)
else: else:
commands.current(verbose, sql_url=str(dburl)) commands.current(verbose, sql_url=str(dburl))
sync_secret_stores_description = ("Sync secret_stores with " # nosec
sync_secret_stores_description = "Sync secret_stores with barbican.conf" "barbican.conf")
@args('--db-url', '-d', metavar='<db-url>', dest='dburl', @args('--db-url', '-d', metavar='<db-url>', dest='dburl',
help='barbican database URL') help='barbican database URL')

2
barbican/common/utils.py
View File

@ -43,7 +43,7 @@ API_VERSION = 'v1'
# barbican.plugin.interface.secret_store which introduces a cyclic dependency # barbican.plugin.interface.secret_store which introduces a cyclic dependency
# if `secret_store` plugin needs to use db model classes. So moving shared # if `secret_store` plugin needs to use db model classes. So moving shared
# value to another common python module which is already imported in both. # value to another common python module which is already imported in both.
SECRET_TYPE_OPAQUE = "opaque" SECRET_TYPE_OPAQUE = "opaque" # nosec
def _do_allow_certain_content_types(func, content_types_list=[]): def _do_allow_certain_content_types(func, content_types_list=[]):

4
barbican/plugin/dogtag.py
View File

@ -165,8 +165,8 @@ class DogtagKRAPlugin(sstore.SecretStoreBase):
BIT_LENGTH = "bit_length" BIT_LENGTH = "bit_length"
GENERATED = "generated" GENERATED = "generated"
KEY_ID = "key_id" KEY_ID = "key_id"
SECRET_MODE = "secret_mode" SECRET_MODE = "secret_mode" # nosec
PASSPHRASE_KEY_ID = "passphrase_key_id" PASSPHRASE_KEY_ID = "passphrase_key_id" # nosec
CONVERT_TO_PEM = "convert_to_pem" CONVERT_TO_PEM = "convert_to_pem"
# string constants # string constants

2
barbican/plugin/interface/secret_store.py
View File

@ -278,7 +278,7 @@ class SecretType(object):
PRIVATE = "private" PRIVATE = "private"
"""Constant to define the passphrase type. Used by getSecret to retrieve a """Constant to define the passphrase type. Used by getSecret to retrieve a
passphrase.""" passphrase."""
PASSPHRASE = "passphrase" PASSPHRASE = "passphrase" # nosec
"""Constant to define the certificate type. Used by getSecret to retrieve a """Constant to define the certificate type. Used by getSecret to retrieve a
certificate.""" certificate."""
CERTIFICATE = "certificate" CERTIFICATE = "certificate"

2
tox.ini
View File

@ -149,7 +149,7 @@ exclude = .git,.idea,.tox,bin,dist,debian,rpmbuild,tools,*.egg-info,*.eggs,contr
[testenv:bandit] [testenv:bandit]
basepython = python3 basepython = python3
deps = -r{toxinidir}/test-requirements.txt deps = -r{toxinidir}/test-requirements.txt
commands = bandit -r barbican -x tests -n5 -s B105 commands = bandit -r barbican -x tests -n5
[testenv:bindep] [testenv:bindep]
basepython = python3 basepython = python3