openstack/charm-ceph-dashboard
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1:

(3 comments)

Patch-set: 1
CC: Gerrit User 15382 <15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34952 \u003c34952@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
Gerrit User 15382
2023-09-01 08:15:07 +00:00
committed by Gerrit Code Review
parent 1047cfb4d8
commit 0e9623e6e4
1 changed files with 51 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

51
7458d95397f40006bb0657ba49a3c571a558740e
View File

@@ -16,6 +16,57 @@
"message": "Error Print: (95) Operation not supported Module \u0027dashboard\u0027 is not enabled (required by command \u0027dashboard set-ssl-certificate\u0027)",
"revId": "7458d95397f40006bb0657ba49a3c571a558740e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "2f0506fa_4dd1ab38",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 1
},
"lineNbr": 0,
"author": {
"id": 15382
},
"writtenOn": "2023-09-01T08:15:07Z",
"side": 1,
"message": "Thanks Utkarsh for the quick patch, it lgtm in general, two questions inline",
"revId": "7458d95397f40006bb0657ba49a3c571a558740e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ed7910e6_abcaf063",
"filename": "src/charm.py",
"patchSetId": 1
},
"lineNbr": 736,
"author": {
"id": 15382
},
"writtenOn": "2023-09-01T08:15:07Z",
"side": 1,
"message": "I wonder if it would make sense to do `ceph_utils.mgr_enable_dashboard()` instead of defering?",
"revId": "7458d95397f40006bb0657ba49a3c571a558740e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ea00dbd2_b109fd60",
"filename": "src/charm.py",
"patchSetId": 1
},
"lineNbr": 752,
"author": {
"id": 15382
},
"writtenOn": "2023-09-01T08:15:07Z",
"side": 1,
"message": "Similar to above, would it make sense to enable the dashboard instead of defer?",
"revId": "7458d95397f40006bb0657ba49a3c571a558740e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}