parent
13e903b244
commit
141b49d9bb
|
@ -16,6 +16,23 @@
|
|||
"message": "This is a follow-up to https://review.opendev.org/c/openstack/charm-ceph-osd/+/869619/",
|
||||
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
},
|
||||
{
|
||||
"unresolved": true,
|
||||
"key": {
|
||||
"uuid": "c4c8203c_33272995",
|
||||
"filename": "hooks/ceph_hooks.py",
|
||||
"patchSetId": 1
|
||||
},
|
||||
"lineNbr": 441,
|
||||
"author": {
|
||||
"id": 34352
|
||||
},
|
||||
"writtenOn": "2023-09-15T03:00:40Z",
|
||||
"side": 1,
|
||||
"message": "Not sure how pythonic all this is, but it was fun playing with enums. The alternative I guess would be to add a `is_valid_tune_osd_memory_target() -\u003e bool` function, but feels like repeating logic.",
|
||||
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
|
||||
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
||||
}
|
||||
]
|
||||
}
|
Loading…
Reference in New Issue