openstack/charm-ceph-osd
Code Issues Proposed changes

Update patch set 8

Browse Source 
Patch Set 8:

(1 comment)

Patch-set: 8
Attention: {"person_ident":"Gerrit User 8108 \u003c8108@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_8108\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 34352 \u003c34352@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_8108\u003e replied on the change"}
This commit is contained in:
Gerrit User 8108
2023-01-12 07:25:59 +00:00
committed by Gerrit Code Review
parent b42c35f8e9
commit 565ed50a3d
1 changed files with 21 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
939c0de0a25cf9ba481fd803a958d4d0b896169e Normal file
View File

@@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": true,
"key": {
"uuid": "f7c6fcc9_5e4be9e5",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 8
},
"lineNbr": 542,
"author": {
"id": 8108
},
"writtenOn": "2023-01-12T07:25:59Z",
"side": 1,
"message": "nit picking: this part could be in relation_set of mon in prepare_disks_and_activate() so we can make sure this tuning is applied not only from config-changed.",
"revId": "939c0de0a25cf9ba481fd803a958d4d0b896169e",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}