openstack/charm-ceph-osd
Code Issues Proposed changes

Update patch set 1

Browse Source 
Patch Set 1:

(2 comments)

Patch-set: 1
CC: Gerrit User 33717 <33717@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
This commit is contained in:
Gerrit User 33717 2023-09-21 20:44:26 +00:00 committed by Gerrit Code Review
parent d9412a7dc8
commit 71078f2ce3
1 changed files with 34 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
23db141218d8a3cd0ff506f2a05c60db484034aa
View File

@ -17,6 +17,40 @@
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa", "revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543" "serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}, },
{
"unresolved": true,
"key": {
"uuid": "c3ea78ad_76bf264c",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 398,
"author": {
"id": 33717
},
"writtenOn": "2023-09-21T20:44:26Z",
"side": 1,
"message": "I think something like a static method for an ergonomic constructor could make things clearer. Something like:\n\n```\n@staticmethod\ndef make(value\u003d\"\", parsed_type\u003dOSDMemoryTargetType.EMPTY):\n return OSDMemoryTarget(value\u003dvalue, parsed_type\u003dparsed_type)\n```\n\nAnd then use it below.",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "ebb40201_1adf1b0c",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 412,
"author": {
"id": 33717
},
"writtenOn": "2023-09-21T20:44:26Z",
"side": 1,
"message": "Return type needs updating.",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{ {
"unresolved": true, "unresolved": true,
"key": { "key": {