openstack
/
charm-ceph-osd
Code Issues Proposed changes

Update patch set 1 

Patch Set 1:

(1 comment)

Patch-set: 1
CC: Gerrit User 15382 <15382@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Attention: {"person_ident":"Gerrit User 34352 \u003c34352@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_15382\u003e replied on the change"}
This commit is contained in:
Gerrit User 15382 2023-09-18 11:41:40 +00:00 committed by Gerrit Code Review
parent 141b49d9bb
commit d9412a7dc8
1 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
23db141218d8a3cd0ff506f2a05c60db484034aa
View File

@ -33,6 +33,24 @@
"message": "Not sure how pythonic all this is, but it was fun playing with enums. The alternative I guess would be to add a `is_valid_tune_osd_memory_target() -\u003e bool` function, but feels like repeating logic.",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0256237c_83a1a6e5",
"filename": "hooks/ceph_hooks.py",
"patchSetId": 1
},
"lineNbr": 441,
"author": {
"id": 15382
},
"writtenOn": "2023-09-18T11:41:40Z",
"side": 1,
"message": "\u003e Not sure how pythonic all this is, but it was fun playing with enums. The alternative I guess would be to add a `is_valid_tune_osd_memory_target() -\u003e bool` function, but feels like repeating logic.\n\nI believe the enum type works fine here. \n\nPossibly could consider using a frozen dataclass instead of namedtuple here, and could move the parsing logic into a __post_init__() method, for some added safety and flexibility, but I wouldn\u0027t block over it.",
"parentUuid": "c4c8203c_33272995",
"revId": "23db141218d8a3cd0ff506f2a05c60db484034aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}