Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata. Dev release tests are enabled separately
because of chickens and eggs.
Change-Id: I675ab7a6a86e0f03c72f979b37b4135868adb953
Unit tests generally will all be executed, and measuring them will
skew the overall coverage numbers. Thus, I'm excluding the unit_tests
folder.
Change-Id: Iec5e57b305615d4d3fe87cb46b771d92d14a5195
This technique was borrowed from the tox "cover" environment in
openstack/nova's tox.ini. This leverages the fact that stestr lets
you override the python executable via the PYTHON environment
variable. Doing this allows us to easily generate coverage for our
unit tests.
An important caveat is that this does not provide any coverage for
tests via zaza, amulet, etc. It is purely focused on the unit tests.
Note that this replaces the previous .coveragerc; coverage
configuration is instead pulled from tox.ini.
Change-Id: I2a14d3a3b0215aa637bc18e780d1ad765c796daa
Use cases for the Ceph pool application name tagging is emerging
and thus far the protocol appears to be ``rbd`` or ``rgw``. Others
might emerge too.
We make use of this to provide "it just works" behaviour to the
ongoing ``rbd-mirror`` feature work in the Ceph charms.
Sync charm-helpers.
Change-Id: Id8e59abdf5aaf578e9f11a223a79209fa971f51c
Using the new version of the sync tool which removes the charmhelpers
directory before syncing, run charm helpers sync to find any unexpected
missing dependencies.
Change-Id: I4d9b743ffb93ce5cc006a1a6050b745c7592fd39
The pre-install operations may fail, yet that failure is not
elevated to the user. This masks the failure and makes early
package install issues difficult to troubleshoot.
If the basic pre-install script fails, the charm should not
proceed to later hooks as the requirements may not be met.
Hashbangs for bash should specify -e (errexit) on all of the
pre-install bash scripts.
Change-Id: I67b3a965b11844a2768800225396927f17864116
Closes-bug: #1815243
Partial-bug: #1815231
In some situations an existing rbd pool may already be populated
with images that are in use. This is the case when migrating
from the old topology where cinder had a direct relation to
ceph-mon.
Change-Id: I93eb801ca4a166f862d5d86711d9476c61851344
Test checks for the removal of ceph.conf alternatives when ceph-mon
relation is broken. If ceph.conf is not present when the relation is
still joined, the test fails. If ceph.conf is not removed after the
relation is broken, the test fails. The test will pass if an existing
ceph.conf file is removed after the ceph-mon relation is broken.
Change-Id: I3b348a58bd2e3ebbbecbd3bbb4307c490a0c4ea4
Related-Bug: 1778084
When adding ceph-mon relation to cinder, the charm installs ceph.conf
with the update-alternatives via cinder_utils.resource_map().
However when the relation is removed, the alternative isn't cleaned up.
This can cause issues if installing a cinder-ceph subordinate charm.
The cinder-ceph charm also installs a ceph.conf alternative that will
point to the leftover ceph.conf installed by the ceph-mon charm.
Added remove_alternative() in ceph-relation-broken hook to ensure
that leftover ceph.conf alternatives is removed upon relation removal.
Change-Id: I308e62a626f31eb8ef690a09035fe3908920ccc9
Closes-Bug: 1778084
We want to default to running all tox environments under python 3, so
set the basepython value in each environment.
We do not want to specify a minor version number, because we do not
want to have to update the file every time we upgrade python.
We do not want to set the override once in testenv, because that
breaks the more specific versions used in default environments like
py35 and py36.
Change-Id: I2068cc2748021157c6d5e4f4b6cbd85790dd11b7
Signed-off-by: Doug Hellmann <doug@doughellmann.com>
By default nova/libvirt will not enable trim for
attached volumes so to allow users to use this
feature we now enable it by default.
Also removed < Icehouse unit test.
Change-Id: I58ffaa43e2836068aeed7795df670d279d5e28f8
Closes-Bug: #1781382
Add a tactical change which is already merged into charm-helpers.
This needs to go into all charms to solve the chicken:egg issue
where cosmic is untestable until this change exists.
Reference:
4835c6c167
Change-Id: Ic979610078651e4479f2c251c809e7ff3f542e73
Misc updates for rocky:
- Switch default smoke test to bionic-rocky
- Resync charm helpers
The change for this charm is minimal as it directly uses
ceph-common. The cinder charm actually deals with installation
of the required python-rados/rbd libraries for the ceph
integration.
Change-Id: Ic2ee4b845ab604d80b7e27492f522d57f9463af1
As of the of the queens release cinder supports this config
option which, if enabled, stops cinder from query all
volumes in a pool every time it does a delete in order to
get accurate pool usage stats. The problem is that this
causes tons of non-fatal race conditions and slows down deletes
to the point where the rpc thread pool fills up blocking
further requests. Our charms do not configure pool by default
and we are not aware of anyone doing this in the field so
this patch enables this option by default.
Change-Id: I5377e2886a6e206d30bd7dc38a7e43a085aa524c
Closes-Bug: 1789828
This is a mechanically generated patch to complete step 1 of moving
the zuul job settings out of project-config and into each project
repository.
Because there will be a separate patch on each branch, the branch
specifiers for branch-specific jobs have been removed.
Because this patch is generated by a script, there may be some
cosmetic changes to the layout of the YAML file(s) as the contents are
normalized.
See the python3-first goal document for details:
https://governance.openstack.org/tc/goals/stein/python3-first.html
Change-Id: I2dbd91d4a486ca0bfe2ad4d3196b55c13d24a5ef
Story: #2002586
Task: #24317
Ensure that EOL releases are removed from metadata
and tests, and that the current dev release is enabled
in metadata. Dev release tests are enabled separately
because of chickens and eggs.
Change-Id: Ib4441a6fa515e2e320c68a8a765a2f30ee74f4ca
Due to changes to the ceph-osd charm, it is
suggested to use Juju storage for testing.
Change-Id: I14ab9533a53105f8edc2c4af1d98b336a898df00
Related-Bug: #1698154
Drop generation of upstart override file and /etc/environment
and scrub any existing charm configuration in these locations
from an existing install.
These where required way back in the dawn of time when ceph
support was alpha/beta in cinder.
Provide backend specific configuration file path, allowing
multiple ceph clusters to be used with a single cinder
application.
Change-Id: I8a097e4de1c5c980f118a587a1a64792fad2fa05
Closes-Bug: 1769196
As of pip 10.0, --allow-unverified is not permitted.
Use of the flag in this repo was previously used to force
installation of python-apt to accommodate certain unit tests.
The unverified package, python-apt, is no longer necessary
for test execution.
Related-Bug: #1760720
Change-Id: I9516fa288f9b04c8822c707e8649916a3f8e0fc6
The charm has been assuming that the principle charm will install
the packages this charm needs to run. This is not always the case
so the change forces the charm to install what it needs.
Change-Id: I1a394bd9f0a008a403d36ba5d7332b7fb5659006
Closes-Bug: #1754007