openstack
/
charm-glance
Code Issues Proposed changes

Update patch set 2 

Patch Set 2: Code-Review-1

(1 comment)

Patch-set: 2
Reviewer: Gerrit User 14567 <14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 477b692405a24101eb558c89f077ceccca42bf61
This commit is contained in:
Gerrit User 14567 2024-03-22 15:07:21 +00:00 committed by Gerrit Code Review
parent c73c312b7a
commit 078948a454
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
07da644b2ba6a2371cf7ef5249e196f18a3b8823
View File

@ -16,6 +16,29 @@
"message": "recheck\n\nthe constraint was updated - https://github.com/openstack-charmers/zaza-openstack-tests/pull/1194",
"revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "0f642968_7cb4996a",
"filename": "hooks/glance_contexts.py",
"patchSetId": 2
},
"lineNbr": 379,
"author": {
"id": 14567
},
"writtenOn": "2024-03-22T15:07:21Z",
"side": 1,
"message": "there is no else to this IF. So, if cinder_volume_types is used, and there is no keystone_ctx to fill the other properties, then it will arrive at an error state that is causing the bug. Shouldn\u0027t it print an error message saying that there is a config problem or something so the error isn\u0027t triggered, and highlights that there is something to be fixed to the operator? If this is an error state that should not be ignored, we could raise an exception here and let the charm status be error so the operator fixes it.",
"range": {
"startLine": 379,
"startChar": 20,
"endLine": 379,
"endChar": 36
},
"revId": "07da644b2ba6a2371cf7ef5249e196f18a3b8823",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}