Update patch set 3

Patch Set 3:

(1 comment)

Patch-set: 3
Attention: {"person_ident":"Gerrit User 33717 \u003c33717@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_935\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 935 \u003c935@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_935\u003e replied on the change"}
This commit is contained in:
Gerrit User 935 2022-09-09 14:48:13 +00:00 committed by Gerrit Code Review
parent 6e3b18ce4c
commit 7420ba5571
1 changed files with 18 additions and 0 deletions

View File

@ -16,6 +16,24 @@
"message": "why are we iterating through all the relations instead of just going through the ones in `relation_info` as before ?\n\nIt seems as though this could be called multiple times - which is fine - except there doesn\u0027t appear to be any way to ensure that we aren\u0027t sending slightly different relation information.",
"revId": "9ad5cade97e14b672ac859d34040353c3a40c7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "e064879b_a1f51b7b",
"filename": "requires.py",
"patchSetId": 3
},
"lineNbr": 166,
"author": {
"id": 935
},
"writtenOn": "2022-09-09T14:48:13Z",
"side": 1,
"message": "This in effect reproduces what set_remote does in the old RelationBase class with Scope.GLOBAL - when data is set, it gets set across all instances of the relation associated with the endpoint.\n\nrelation_info is just the dict of keys that gets keyword expanded by **.",
"parentUuid": "4c6da810_643f1a1c",
"revId": "9ad5cade97e14b672ac859d34040353c3a40c7aa",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}