openstack/charm-keystone
Code Issues Proposed changes

Fix lint errors E741 and E741

Browse Source 
hooks/keystone_utils.py:1606:9:
 E741 ambiguous variable name 'l'

actions/security_checklist.py:52:13:
 F523 '...'.format(...) has unused arguments at position(s): 0

Change-Id: I84f33cfd574483a36b8201a0a6b4f970f8cb8175
This commit is contained in:
Corey Bryant 2020-05-21 13:19:58 -04:00
parent 8296fa4e29
commit 4c316350cc
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
actions/security_checklist.py
View File

@ -49,7 +49,7 @@ def uses_sha256_for_hashing_tokens(audit_options):
algorithm = section.get("hash_algorithm")
if provider and "pki" in provider:
assert "SHA256" == algorithm, \
"Weak hash algorithm used with PKI provider: ".format(
"Weak hash algorithm used with PKI provider: {}".format(
algorithm)

4
hooks/keystone_utils.py
View File

@ -1603,8 +1603,8 @@ def load_stored_passwords(path=SERVICE_PASSWD_PATH):
return creds
stored_passwd = open(path, 'r')
for l in stored_passwd.readlines():
user, passwd = l.strip().split(':')
for _line in stored_passwd.readlines():
user, passwd = _line.strip().split(':')
creds[user] = passwd
return creds