openstack
/
charm-nova-compute
Code Issues Proposed changes

Update patch set 3 

Patch Set 3: Code-Review-1

(1 comment)

Patch-set: 3
Reviewer: Gerrit User 10058 <10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, 2bb6f2b1a2c1513d3dd8aef3269e990e61e4c9cf
Attention: {"person_ident":"Gerrit User 10058 \u003c10058@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 14567 \u003c14567@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_10058\u003e replied on the change"}
This commit is contained in:
Gerrit User 10058 2024-04-22 23:45:39 +00:00 committed by Gerrit Code Review
parent 58f61086b6
commit e0125a2954
1 changed files with 17 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
2ef454c7bd556f3a425b40792899d7dc1f76eed5
View File

@ -16,6 +16,23 @@
"message": "charm-recheck",
"revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {
"uuid": "38e57b97_84f8da0e",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 10058
},
"writtenOn": "2024-04-22T23:45:39Z",
"side": 1,
"message": "This approach does not look correct to me. The bottom line is that we are adding a fix to charm-ovn-xxx on charm-nova-compute. This will be hard to control once we have more of this kind of cross-charm fixes.\nThe second thing I see here is that we are loading a module to nf_conntrack, while there are many other possible values to `sysctl` and we don\u0027t have how to cover all modules or other dependencies from those.\n\nIMO, the responsibility to load and set the module and sysconfig values should be to the networking layer, which should load all sysconfigs and modules it needs. That should be done on install time, not during config-changed.\n\nBTW, charm-neutron-gateway has a fix[1] in those lines, though it also does the module loading during config-changed.\n\n[1] https://review.opendev.org/c/openstack/charm-neutron-gateway/+/738116/4/hooks/neutron_hooks.py#b140",
"revId": "2ef454c7bd556f3a425b40792899d7dc1f76eed5",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}