Add missing unit tests
This commit is contained in:
Frode Nordahl
parent
5057ccc165
commit
273f230e35
|
|
@ -0,0 +1,122 @@
|
|||
# Copyright 2019 Canonical Ltd
|
||||
#
|
||||
# Licensed under the Apache License, Version 2.0 (the "License");
|
||||
# you may not use this file except in compliance with the License.
|
||||
# You may obtain a copy of the License at
|
||||
#
|
||||
# http://www.apache.org/licenses/LICENSE-2.0
|
||||
#
|
||||
# Unless required by applicable law or agreed to in writing, software
|
||||
# distributed under the License is distributed on an "AS IS" BASIS,
|
||||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
# See the License for the specific language governing permissions and
|
||||
# limitations under the License.
|
||||
|
||||
import mock
|
||||
|
||||
import charms_openstack.test_utils as test_utils
|
||||
|
||||
import charm.openstack.glance_retrofitter as glance_retrofitter
|
||||
|
||||
|
||||
class TestGlanceRetrofitter(test_utils.PatchHelper):
|
||||
|
||||
def test_session_from_identity_credentials(self):
|
||||
self.patch_object(
|
||||
glance_retrofitter.keystoneauth1.loading, 'get_plugin_loader')
|
||||
self.patch_object(
|
||||
glance_retrofitter.keystoneauth1.session, 'Session')
|
||||
loader = mock.MagicMock()
|
||||
self.get_plugin_loader.return_value = loader
|
||||
endpoint = mock.MagicMock()
|
||||
result = glance_retrofitter.session_from_identity_credentials(endpoint)
|
||||
self.get_plugin_loader.assert_called_once_with('password')
|
||||
loader.load_from_options.assert_called_once_with(
|
||||
auth_url='{}://{}:{}/'
|
||||
.format(endpoint.auth_protocol(),
|
||||
endpoint.auth_host(),
|
||||
endpoint.auth_port()),
|
||||
user_domain_name=endpoint.credentials_user_domain_name(),
|
||||
project_domain_name=endpoint.credentials_project_domain_name(),
|
||||
project_name=endpoint.credentials_project(),
|
||||
username=endpoint.credentials_username(),
|
||||
password=endpoint.credentials_password())
|
||||
self.Session.assert_called_once_with(
|
||||
auth=loader.load_from_options(),
|
||||
verify=glance_retrofitter.SYSTEM_CA_BUNDLE)
|
||||
self.assertEquals(result, self.Session())
|
||||
|
||||
def test_get_glance_client(self):
|
||||
self.patch_object(glance_retrofitter.glanceclient, 'Client')
|
||||
result = glance_retrofitter.get_glance_client('aSession')
|
||||
self.Client.assert_called_once_with('2', session='aSession')
|
||||
self.assertEquals(result, self.Client())
|
||||
|
||||
def test_get_product_name(self):
|
||||
self.patch_object(glance_retrofitter.subprocess, 'check_output')
|
||||
self.check_output.return_value = 'aArchitecture'
|
||||
self.assertEquals(glance_retrofitter.get_product_name(),
|
||||
'com.ubuntu.cloud.daily:server:18.04:aArchitecture')
|
||||
self.check_output.assert_called_once_with(
|
||||
['dpkg', '--print-architecture'],
|
||||
universal_newlines=True)
|
||||
|
||||
def test_find_image(self):
|
||||
glance = mock.MagicMock()
|
||||
|
||||
class FakeImage1(object):
|
||||
version_name = '20194242'
|
||||
fake_image1 = FakeImage1()
|
||||
|
||||
class FakeImage2(object):
|
||||
version_name = '20195151'
|
||||
fake_image2 = FakeImage2()
|
||||
|
||||
glance.images.list.return_value = [fake_image1, fake_image2]
|
||||
self.assertEquals(
|
||||
glance_retrofitter.find_image(glance, {'fake_property': 'real'}),
|
||||
fake_image2)
|
||||
glance.images.list.assert_called_once_with(
|
||||
filters={'fake_property': 'real'},
|
||||
sort_key='created_at',
|
||||
sort_dir='desc')
|
||||
|
||||
def test_find_destination_image(self):
|
||||
glance = mock.MagicMock()
|
||||
result = glance_retrofitter.find_destination_image(
|
||||
glance, 'aProduct', 'aVersion')
|
||||
glance.images.list.assert_called_once_with(
|
||||
filters={'source_product_name': 'aProduct',
|
||||
'source_version_name': 'aVersion'})
|
||||
self.assertEquals(result, glance.images.list())
|
||||
|
||||
def test_find_source_image(self):
|
||||
self.patch_object(glance_retrofitter, 'get_product_name')
|
||||
self.patch_object(glance_retrofitter, 'find_image')
|
||||
self.get_product_name.return_value = 'aProduct'
|
||||
self.find_image.side_effect = [None, None, None, 'aImage']
|
||||
self.assertEquals(
|
||||
glance_retrofitter.find_source_image('aGlance'),
|
||||
'aImage')
|
||||
self.get_product_name.assert_has_calls([
|
||||
mock.call(stream='daily', variant='server'),
|
||||
mock.call(stream='daily', variant='minimal'),
|
||||
mock.call(stream='released', variant='server'),
|
||||
mock.call(stream='released', variant='minimal'),
|
||||
])
|
||||
self.find_image.assert_called_with(
|
||||
'aGlance', filters={'product_name': 'aProduct'})
|
||||
|
||||
def test_download_image(self):
|
||||
glance = mock.MagicMock()
|
||||
glance.images.data.return_value = ['two', 'Chunks']
|
||||
image = mock.MagicMock()
|
||||
file_object = mock.MagicMock()
|
||||
file_handle = mock.MagicMock()
|
||||
file_object.__enter__.return_value = file_handle
|
||||
glance_retrofitter.download_image(glance, image, file_object)
|
||||
glance.images.data.assert_called_once_with(image.id)
|
||||
file_handle.write.assert_has_calls([
|
||||
mock.call('two'),
|
||||
mock.call('Chunks'),
|
||||
])
|
||||
|
|
@ -13,6 +13,8 @@
|
|||
# limitations under the License.
|
||||
|
||||
import mock
|
||||
import os
|
||||
import subprocess
|
||||
|
||||
import charms_openstack.test_utils as test_utils
|
||||
|
||||
|
|
@ -39,3 +41,71 @@ class TestOctaviaDiskimageRetrofitCharm(test_utils.PatchHelper):
|
|||
c.name,
|
||||
project='services',
|
||||
domain='service_domain')
|
||||
|
||||
def test_retrofit(self):
|
||||
self.patch_object(octavia_diskimage_retrofit, 'glance_retrofitter')
|
||||
glance = mock.MagicMock()
|
||||
self.glance_retrofitter.get_glance_client.return_value = glance
|
||||
|
||||
class FakeImage(object):
|
||||
id = 'aId'
|
||||
name = 'aName'
|
||||
architecture = 'aArchitecture'
|
||||
os_distro = 'aOSDistro'
|
||||
os_version = 'aOSVersion'
|
||||
version_name = 'aVersionName'
|
||||
product_name = 'aProductName'
|
||||
fake_image = FakeImage()
|
||||
|
||||
glance.images.create.return_value = fake_image
|
||||
self.glance_retrofitter.find_source_image.return_value = fake_image
|
||||
self.patch_object(
|
||||
octavia_diskimage_retrofit.tempfile,
|
||||
'NamedTemporaryFile')
|
||||
self.patch_object(octavia_diskimage_retrofit.ch_core, 'hookenv')
|
||||
self.patch_object(octavia_diskimage_retrofit.subprocess,
|
||||
'check_output')
|
||||
c = octavia_diskimage_retrofit.OctaviaDiskimageRetrofitCharm()
|
||||
with mock.patch('charm.openstack.octavia_diskimage_retrofit.open',
|
||||
create=True) as mocked_open:
|
||||
with self.assertRaises(Exception):
|
||||
c.retrofit('aKeystone')
|
||||
self.glance_retrofitter.session_from_identity_credentials.\
|
||||
assert_called_once_with('aKeystone')
|
||||
self.glance_retrofitter.get_glance_client.assert_called_once_with(
|
||||
self.glance_retrofitter.session_from_identity_credentials())
|
||||
self.glance_retrofitter.find_destination_image.return_value = None
|
||||
c.retrofit('aKeystone')
|
||||
self.NamedTemporaryFile.assert_has_calls([
|
||||
mock.call(delete=False,
|
||||
dir=octavia_diskimage_retrofit.TMPDIR),
|
||||
mock.call(delete=False,
|
||||
dir=octavia_diskimage_retrofit.TMPDIR),
|
||||
])
|
||||
self.hookenv.atexit.assert_called_with(os.unlink, mock.ANY)
|
||||
self.hookenv.status_set.assert_has_calls([
|
||||
mock.call('maintenance', 'Downloading aName'),
|
||||
mock.call('maintenance', 'Retrofitting aName'),
|
||||
mock.call('maintenance', 'Uploading aName'),
|
||||
])
|
||||
self.glance_retrofitter.download_image.assert_called_once_with(
|
||||
glance, fake_image, self.NamedTemporaryFile())
|
||||
self.hookenv.config.assert_called_once_with('retrofit-uca-pocket')
|
||||
self.check_output.assert_called_once_with(
|
||||
['octavia-diskimage-retrofit', '-d', '-u',
|
||||
self.hookenv.config(), self.NamedTemporaryFile().name,
|
||||
self.NamedTemporaryFile().name],
|
||||
stderr=subprocess.STDOUT, universal_newlines=True)
|
||||
glance.images.create.assert_called_once_with(
|
||||
container_format='bare',
|
||||
disk_format='qcow2',
|
||||
name='amphora-haproxy-aArchitecture-aOSDistro-aOSVersion-'
|
||||
'aVersionName')
|
||||
glance.images.upload.assert_called_once_with('aId', mock.ANY)
|
||||
mocked_open.assert_called_once_with(
|
||||
self.NamedTemporaryFile().name, 'rb')
|
||||
glance.images.update.assert_called_once_with(
|
||||
'aId',
|
||||
source_product_name='aProductName',
|
||||
source_version_name='aVersionName',
|
||||
tags=['octavia-diskimage-retrofit', 'octavia-amphora'])
|
||||
|
|
|
|||
Loading…
Reference in New Issue