Update patch set 4

Patch Set 4: Code-Review-1

(2 comments)

Patch-set: 4
Reviewer: Gerrit User 20870 <20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1, f354796cfe43c949fe7d2f854562f7d00517e600
Attention: {"person_ident":"Gerrit User 20870 \u003c20870@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_20870\u003e replied on the change"}
This commit is contained in:
Gerrit User 20870 2024-01-08 13:24:00 +00:00 committed by Gerrit Code Review
parent e7c5f9896b
commit 841898ff06
2 changed files with 45 additions and 0 deletions

View File

@ -0,0 +1,21 @@
{
"comments": [
{
"unresolved": false,
"key": {
"uuid": "c1f548bb_20c19e52",
"filename": "/PATCHSET_LEVEL",
"patchSetId": 3
},
"lineNbr": 0,
"author": {
"id": 20870
},
"writtenOn": "2024-01-08T13:24:00Z",
"side": 1,
"message": "Thanks for the updates, and the unit test. The commit message still needs a little more, though, please.",
"revId": "b14d5e76040c8c71a6cbf8c4e4709a14fd92d822",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
}
]
}

View File

@ -23,6 +23,30 @@
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": true,
"key": {
"uuid": "16e3aed9_d46b80ff",
"filename": "/COMMIT_MSG",
"patchSetId": 2
},
"lineNbr": 8,
"author": {
"id": 20870
},
"writtenOn": "2024-01-08T13:24:00Z",
"side": 1,
"message": "This commit message still needs work. Just pointing to a bug creates work for other people when they are viewing the commit message.\n\nPlease see the following for examples:\n\n- https://docs.opendev.org/opendev/infra-manual/latest/developers.html#committing-changes\n- Post on how to write a good commit message: https://cbea.ms/git-commit/\n\nSay what the commit does and why, please.\n\nPlease remove the \"Customer:\" part; this is an open source project and whilst the feature addition may have been prompted due to a customer, it\u0027s still just a feature being added to this open source project.",
"parentUuid": "49d0bfa2_e1b8c956",
"range": {
"startLine": 6,
"startChar": 0,
"endLine": 8,
"endChar": 0
},
"revId": "b2d1dddc27f8f71382a2ff68f56470b51dcdf986",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
},
{
"unresolved": false,
"key": {