110384dd63
Patch Set 14:
(9 comments)
Patch-set: 14
Attention: {"person_ident":"Gerrit User 36623 \u003c36623@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"REMOVE","reason":"\u003cGERRIT_ACCOUNT_36623\u003e replied on the change"}
Attention: {"person_ident":"Gerrit User 935 \u003c935@4a232e18-c5a9-48ee-94c0-e04e7cca6543\u003e","operation":"ADD","reason":"\u003cGERRIT_ACCOUNT_36623\u003e replied on the change"}
91 lines
2.7 KiB
Plaintext
91 lines
2.7 KiB
Plaintext
{
|
|
"comments": [
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "99527c1a_0c9356a4",
|
|
"filename": "/PATCHSET_LEVEL",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 0,
|
|
"author": {
|
|
"id": 935
|
|
},
|
|
"writtenOn": "2024-01-12T15:53:09Z",
|
|
"side": 1,
|
|
"message": "charm-recheck",
|
|
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "da3ba781_91eccc57",
|
|
"filename": "src/README.md",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 244,
|
|
"author": {
|
|
"id": 935
|
|
},
|
|
"writtenOn": "2024-01-12T15:52:48Z",
|
|
"side": 1,
|
|
"message": "apologies - I\u0027d not realised there is not a section about using vault as an intermediate CA - we probably need to put this documentation elsewhere in the main openstack charm guide.",
|
|
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "c1863aec_25592b2b",
|
|
"filename": "src/README.md",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 244,
|
|
"author": {
|
|
"id": 36623
|
|
},
|
|
"writtenOn": "2024-01-17T20:07:22Z",
|
|
"side": 1,
|
|
"message": "I removed this part from doc, But I did not understand to which section of main Openstack Charm Guide I should add it.\n\nhttps://review.opendev.org/c/openstack/charm-guide/+/905611 is the doc update",
|
|
"parentUuid": "da3ba781_91eccc57",
|
|
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": true,
|
|
"key": {
|
|
"uuid": "40e6bef0_226d8504",
|
|
"filename": "src/actions.yaml",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 117,
|
|
"author": {
|
|
"id": 935
|
|
},
|
|
"writtenOn": "2024-01-12T15:52:48Z",
|
|
"side": 1,
|
|
"message": "Please can you wrap the text to be less that 79 chars.",
|
|
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
},
|
|
{
|
|
"unresolved": false,
|
|
"key": {
|
|
"uuid": "ba48caa9_4a5aca30",
|
|
"filename": "src/actions.yaml",
|
|
"patchSetId": 13
|
|
},
|
|
"lineNbr": 117,
|
|
"author": {
|
|
"id": 36623
|
|
},
|
|
"writtenOn": "2024-01-17T20:07:22Z",
|
|
"side": 1,
|
|
"message": "I updated but also updated other lines exceeding 79 bytes.",
|
|
"parentUuid": "40e6bef0_226d8504",
|
|
"revId": "51c42d604fe66fb2c08d1824e8a87d5fbcc3400e",
|
|
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543"
|
|
}
|
|
]
|
|
} |