openstack/cinder
Code Issues Proposed changes

Dell EMC PS: Fix extend volume creating unmanaged snapsots

Browse Source 
The Dell EMC PS driver's extend volume code is missing the
no-snap option and creates unmanaged snapshots in the background.
Added that option to fix it.

Closes Bug: #1720454

Change-Id: I48398331fe086760a88bd5ca4c0f28f90e22bd0b
(cherry picked from commit 0910706e76)
This commit is contained in:
rajinir
2017-10-02 16:22:18 -05:00
committed by Sean McGinnis
parent 047c3f87b5
commit 09b1b13519
2 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cinder/volume/drivers/dell_emc/ps.py
View File

@@ -136,10 +136,11 @@ class PSSeriesISCSIDriver(san.SanISCSIDriver):
1.4.1 - Rebranded driver to Dell EMC. 1.4.1 - Rebranded driver to Dell EMC.
1.4.4 - Fixed over-subscription ratio calculation 1.4.4 - Fixed over-subscription ratio calculation
1.4.5 - Optimize volume stats information parsing 1.4.5 - Optimize volume stats information parsing
1.4.6 - Extend volume with no-snap option
""" """
VERSION = "1.4.5" VERSION = "1.4.6"
# ThirdPartySytems wiki page # ThirdPartySytems wiki page
CI_WIKI_NAME = "Dell_Storage_CI" CI_WIKI_NAME = "Dell_Storage_CI"
@@ -608,7 +609,7 @@ class PSSeriesISCSIDriver(san.SanISCSIDriver):
"""Extend the size of the volume.""" """Extend the size of the volume."""
try: try:
self._eql_execute('volume', 'select', volume['name'], self._eql_execute('volume', 'select', volume['name'],
'size', "%sG" % new_size) 'size', "%sG" % new_size, 'no-snap')
LOG.info(_LI('Volume %(name)s resized from ' LOG.info(_LI('Volume %(name)s resized from '
'%(current_size)sGB to %(new_size)sGB.'), '%(current_size)sGB to %(new_size)sGB.'),
{'name': volume['name'], {'name': volume['name'],

5
releasenotes/notes/ps-extend_volume-no-snap-8aa447c50f2475a7.yaml Normal file
View File

@@ -0,0 +1,5 @@
---
fixes:
- Dell EMC PS Series Driver was creating unmanaged snapshots
when extending volumes. Fixed it by adding the missing
no-snap parameter. This change fixes bug 1720454.