openstack
/
cinder
Code Issues Proposed changes

pylint: Fix migration E1120 no-value-for-parameter 

Pylint raises E1120 on all many of our migrations because the insert
call is missing the dml parameter:

  cinder/db/sqlalchemy/migrate_repo/versions/123_cinder_init.py:870:9:
  E1120: No value for argument 'dml' in method call
  (no-value-for-parameter)

The dml parameter is automatically added by sqlalchemy using a
decorator, like this:

    @util.dependencies("sqlalchemy.sql.dml")
    def insert(self, dml, values=None, inline=False, **kwargs):

This patch adds the decorator to the pyling configured
signature-mutators to remove these errors from incorrectly showing.

Change-Id: Icbc72b3655f379c9b97134e68a425dc1d623dc7b
This commit is contained in:
Gorka Eguileor 2021-04-16 12:59:29 +02:00
parent 764bc3c5d8
commit 15d8ad15d2
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.pylintrc
View File

@ -222,7 +222,7 @@ additional-builtins=_
[TYPECHECK]
# List of module names for which member attributes should not be checked
ignored-modules=six.moves,_MovedItems
signature-mutators=unittest.mock.patch,unittest.mock.patch.object
signature-mutators=unittest.mock.patch,unittest.mock.patch.object,sqlalchemy.util._preloaded.dependencies
# This is for cinder.objects.*, and requests.packages.*, but due to
# https://github.com/PyCQA/pylint/issues/2498