openstack
/
cinder
Code Issues Proposed changes

Remove unneeded volume_types.get_all_types_by_group method 

This is only used by the VolumeType object -- other users
in Cinder should just call via the object instead of this
method.

Change-Id: I7adc1d1208fb36a9a0cc670d41f779486b137802
This commit is contained in:
Eric Harney 2022-03-30 11:32:08 -04:00
parent 04da59177d
commit 2c4e0d4f8f
2 changed files with 1 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/objects/volume_type.py
View File

@ -184,7 +184,7 @@ class VolumeTypeList(base.ObjectListBase, base.CinderObject):
@classmethod
def get_all_by_group(cls, context, group_id):
# Generic volume group
types = volume_types.get_all_types_by_group(
types = db.volume_type_get_all_by_group(
context.elevated(), group_id)
expected_attrs = VolumeType._get_expected_attrs(context)
return base.obj_make_list(context, cls(context),

6
cinder/volume/volume_types.py
View File

@ -158,12 +158,6 @@ def get_all_types(context, inactive=0, filters=None, marker=None,
return vol_types
def get_all_types_by_group(context, group_id):
"""Get all volume_types in a group."""
vol_types = db.volume_type_get_all_by_group(context, group_id)
return vol_types
def get_volume_type(ctxt, id, expected_fields=None):
"""Retrieves single volume type by id."""
if id is None: