openstack/cinder
Code Issues Proposed changes

HPE: Fix keyerror seen during volume migration

Browse Source 
Refactors _get_updated_comments to retrieve updated comment via Volume.get().
This prevents a KeyError when getting comment during volume migration.

Closes-Bug: #2008931
Change-Id: Ic0cfa68172d2b0607928b35fec081da96e33c434
This commit is contained in:
Desire Barine 2023-03-15 20:14:34 +00:00
parent 42d5d1d648
commit 955ac9e3fc
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cinder/volume/drivers/hpe/hpe_3par_common.py
View File

@ -3092,7 +3092,7 @@ class HPE3PARCommon(object):
def _get_updated_comment(self, vol_name, **values):
vol = self.client.getVolume(vol_name)
comment = json.loads(vol['comment']) if vol['comment'] else {}
comment = json.loads(vol['comment']) if vol.get('comment') else {}
comment.update(values)
def _update_comment(self, vol_name, **values):

7
releasenotes/notes/bug-2008931-hpe-keyerror-on-migration-71d31e6c0a8ab0d9.yaml Normal file
View File

@ -0,0 +1,7 @@
---
fixes:
- |
HPE 3PAR driver `bug #2008931
<https://bugs.launchpad.net/cinder/+bug/2008931>`_: Fixed
issue when performing migrate volume operation when `comment`
attribute is missing from the volume.