Browse Source

Remove superfluous role_name arguments

This patch removes the role_name when using openstack_user's :create
action (it gets ignored by the target method).

Note that the spec test would still pass if only the line in
identity_registration.rb (but not the test) were changed, because the
code that actually does grant the role to the resource is executed right
after user creation and before any tests check the resource for the
existence of the role_name attribute. In other words: if the argument
were required in a call but only supplied in another call, the spec
tests would not catch it. Something to watch out for.

Change-Id: I320d0e85287aa5d6368d5be323999f8d9e1c462f
Roger Luethi 1 year ago
parent
commit
e5e8bb9326
2 changed files with 0 additions and 2 deletions
  1. 0
    1
      recipes/identity_registration.rb
  2. 0
    1
      spec/identity_registration_spec.rb

+ 0
- 1
recipes/identity_registration.rb View File

@@ -80,7 +80,6 @@ end
80 80
 # Register Service User
81 81
 openstack_user service_user do
82 82
   project_name service_project_name
83
-  role_name service_role
84 83
   password service_pass
85 84
   connection_params connection_params
86 85
 end

+ 0
- 1
spec/identity_registration_spec.rb View File

@@ -74,7 +74,6 @@ describe 'openstack-block-storage::identity_registration' do
74 74
         service_user
75 75
       ).with(
76 76
         project_name: project_name,
77
-        role_name: role_name,
78 77
         password: password,
79 78
         connection_params: connection_params
80 79
       )

Loading…
Cancel
Save