openstack
/
cookbook-openstack-dashboard
Code Issues Proposed changes

Update patch set 4 

Patch Set 4: Code-Review-1

(1 comment)

Please also fix the ChefSpec issues.

Patch-set: 4
Reviewer: Gerrit User 21961 <21961@4a232e18-c5a9-48ee-94c0-e04e7cca6543>
Label: Code-Review=-1
This commit is contained in:
Gerrit User 21961 2021-07-15 23:30:46 +00:00 committed by Gerrit Code Review
parent 2982da0b80
commit 6db7723081
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
136df9a295cbc7890090737bdbe10483e0f915c2 Normal file
View File

@ -0,0 +1,21 @@
{
"comments": [
{
"key": {
"uuid": "4b6f5c03_a03ed41b",
"filename": "attributes/default.rb",
"patchSetId": 4
},
"lineNbr": 122,
"author": {
"id": 21961
},
"writtenOn": "2021-07-15T23:30:46Z",
"side": 1,
"message": "It looks like this breaks on Ubuntu 18.04 since this is covering the platform_family. We technically only support RHEL/Ubuntu however if you want to add some logic here testing on the platform ubuntu vs. debian, that\u0027s OK with me. We just won\u0027t be testing it on our end.",
"revId": "136df9a295cbc7890090737bdbe10483e0f915c2",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": true
}
]
}