cookbook-openstack-integrat.../d9d7b11b08495f2d22b23ce7e56e670c1e0286b8
Gerrit User 21961 a3c3b58432 Update patch set 6
Patch Set 6:

(2 comments)

Patch-set: 6
Label: Verified=0
2020-01-29 18:23:21 +00:00

85 lines
2.4 KiB
Plaintext

{
"comments": [
{
"key": {
"uuid": "3fa7e38b_3aecacba",
"filename": "attributes/tempest_conf.rb",
"patchSetId": 6
},
"lineNbr": 144,
"author": {
"id": 13252
},
"writtenOn": "2020-01-29T11:38:31Z",
"side": 1,
"message": "Wouldn\u0027t you need to set this to true in order to run cinder tests at all?",
"revId": "d9d7b11b08495f2d22b23ce7e56e670c1e0286b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_2d9d3cb9",
"filename": "attributes/tempest_conf.rb",
"patchSetId": 6
},
"lineNbr": 144,
"author": {
"id": 21961
},
"writtenOn": "2020-01-29T18:23:21Z",
"side": 1,
"message": "This gets set to true in the role in openstack-cinder. But I suppose if you don\u0027t use that and you want to use this out right, it probably should be enabled. I also should remove some of these services as they no longer exist in tempest.",
"parentUuid": "3fa7e38b_3aecacba",
"revId": "d9d7b11b08495f2d22b23ce7e56e670c1e0286b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_1a62103e",
"filename": "recipes/setup.rb",
"patchSetId": 6
},
"lineNbr": 84,
"author": {
"id": 13252
},
"writtenOn": "2020-01-29T11:38:31Z",
"side": 1,
"message": "Looks like this should happen outside of the loop and thus be executed only once.",
"range": {
"startLine": 80,
"startChar": 2,
"endLine": 84,
"endChar": 5
},
"revId": "d9d7b11b08495f2d22b23ce7e56e670c1e0286b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
},
{
"key": {
"uuid": "3fa7e38b_3aa4ac4b",
"filename": "recipes/setup.rb",
"patchSetId": 6
},
"lineNbr": 181,
"author": {
"id": 13252
},
"writtenOn": "2020-01-29T11:38:31Z",
"side": 1,
"message": "tempest",
"range": {
"startLine": 181,
"startChar": 57,
"endLine": 181,
"endChar": 61
},
"revId": "d9d7b11b08495f2d22b23ce7e56e670c1e0286b8",
"serverId": "4a232e18-c5a9-48ee-94c0-e04e7cca6543",
"unresolved": false
}
]
}