Upgrade rubocop

Rubocop 0.18.1 has been released, which includes the reported
inconsistent class documentation cop triggering fix. This release also
contains some new cops and fixes others, triggering new violations on
existing rubocopped code.

- Upgrade rubocop to 0.18.1
- Fix new/corrected violations

Change-Id: Ia66ce8521c06a94bc28928784161d657da50f215
Addresses: blueprint rubocop-for-object-storage

Gemfile

@@ -6,4 +6,4 @@ gem 'berkshelf', '~> 2.0.10'
 gem 'chefspec', '~> 3.1.4'
 gem 'foodcritic', '~> 3.0.3'
 gem 'strainer'
-gem 'rubocop', '>= 0.16.0'
+gem 'rubocop', '~> 0.18.1'

Gemfile.lock

@@ -135,7 +135,7 @@ GEM
       mixlib-shellout
       systemu (~> 2.5.2)
       yajl-ruby
-    parser (2.1.2)
+    parser (2.1.4)
       ast (~> 1.1)
       slop (~> 3.4, >= 3.4.5)
     polyglot (0.3.3)
@@ -147,7 +147,7 @@ GEM
     puma (1.6.3)
       rack (~> 1.2)
     rack (1.5.2)
-    rainbow (1.99.1)
+    rainbow (2.0.0)
     rake (10.1.0)
     rbzip2 (0.2.0)
     rest-client (1.6.7)
@@ -181,10 +181,11 @@ GEM
     rspec-expectations (2.14.4)
       diff-lcs (>= 1.1.3, < 2.0)
     rspec-mocks (2.14.4)
-    rubocop (0.16.0)
-      parser (~> 2.1)
+    rubocop (0.18.1)
+      json (>= 1.7.7, < 2)
+      parser (~> 2.1.3)
       powerpack (~> 0.0.6)
-      rainbow (>= 1.1.4)
+      rainbow (>= 1.99.1, < 3.0)
     rubyntlm (0.1.1)
     savon (0.9.5)
       akami (~> 1.0)
@@ -230,5 +231,5 @@ DEPENDENCIES
   chefspec (~> 3.1.4)
   foodcritic (~> 3.0.3)
   json (<= 1.7.7)
-  rubocop (>= 0.16.0)
+  rubocop (~> 0.18.1)
   strainer

recipes/common.rb

@@ -18,7 +18,7 @@
 # limitations under the License.
 #
 
-class Chef::Recipe
+class Chef::Recipe # rubocop:disable Documentation
   include DriveUtils
 end
 

recipes/disks.rb

@@ -20,7 +20,7 @@
 # Author: Ron Pedde <ron.pedde@rackspace.com>
 # Inspired by: Andi Abes @ Dell
 
-class Chef::Recipe
+class Chef::Recipe # rubocop:disable Documentation
   include IPUtils
   include DriveUtils
 end

recipes/ring-repo.rb

@@ -74,8 +74,8 @@ template '/etc/systemd/system/git.service' do
   variables(
     description: 'Git daemon service',
     user: 'nobody',
-    exec: '/usr/libexec/git-core/git-daemon ' +
-             '--base-path=/var/lib/git --export-all --user-path=public_git' +
+    exec: '/usr/libexec/git-core/git-daemon ' \
+             '--base-path=/var/lib/git --export-all --user-path=public_git' \
              '--syslog --verbose'
   )
   only_if { platform?('fedora') }