openstack/deb-cinder
Code Issues Proposed changes

add FIXME tag for extra argument 'topic' in scheduler rpc api

Browse Source 
Some functions in scheduler rpc api receive unused argument
'topic'. We can't fix it now as we may interact with old services.
It can only be fixed when we do a major version bump and drop the
old compatibility. Now we add two FIXME tags in case we forget it
one day.

Change-Id: Iafd60bb51a2d7c8eab909d35f4b4de120a1172bb
Partial-Bug: #1593149
This commit is contained in:
Cao ShuFeng 2016-06-19 07:47:35 -04:00
parent 025213a6b1
commit 505b8388d1
2 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
cinder/scheduler/manager.py
View File

@ -56,6 +56,10 @@ LOG = logging.getLogger(__name__)
class SchedulerManager(manager.Manager): class SchedulerManager(manager.Manager):
"""Chooses a host to create volumes.""" """Chooses a host to create volumes."""
# FIXME(caosf): Remove unused argument 'topic' from functions
# create_consistencygroup(), create_volume(), migrate_volume_to_host(),
# retype() and manage_existing() in v3.0 of RPC API.
RPC_API_VERSION = '2.1' RPC_API_VERSION = '2.1'
target = messaging.Target(version=RPC_API_VERSION) target = messaging.Target(version=RPC_API_VERSION)

4
cinder/scheduler/rpcapi.py
View File

@ -59,6 +59,10 @@ class SchedulerAPI(rpc.RPCAPI):
TOPIC = CONF.scheduler_topic TOPIC = CONF.scheduler_topic
BINARY = 'cinder-scheduler' BINARY = 'cinder-scheduler'
# FIXME(caosf): Remove unused argument 'topic' from functions
# create_consistencygroup(), create_volume(), migrate_volume_to_host(),
# retype() and manage_existing() in v3.0 of RPC API.
def create_consistencygroup(self, ctxt, topic, group, def create_consistencygroup(self, ctxt, topic, group,
request_spec_list=None, request_spec_list=None,
filter_properties_list=None): filter_properties_list=None):