openstack/deb-python-ceilometerclient
Code Issues Proposed changes

Avoid unnecessary stderr message when run test

Browse Source 
Currently, if we run `tox -epy27`, we will get an useless stderr
message 'HTTPUnauthorized (HTTP 401)', which is triggered on purpose
by a test. It should be mocked because it provides no such useful message.

Change-Id: I009310257741a34fe966d6d745de3c6cf58e0feb
Closes-Bug: #1323480
This commit is contained in:
ZhiQiang Fan
2014-05-27 12:26:40 +08:00
parent cb11c9bb3d
commit 7390d78d95
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
ceilometerclient/tests/test_shell.py
View File

@@ -109,8 +109,9 @@ class ShellTest(utils.BaseTestCase):
args = ['-d', 'event-list']
self.assertRaises(exc.CommandError, ceilometer_shell.main, args)
@mock.patch('sys.stderr')
@mock.patch.object(ksclient, 'Client')
def test_no_debug_switch_no_raises_errors(self, mock_ksclient):
def test_no_debug_switch_no_raises_errors(self, mock_ksclient, __):
mock_ksclient.side_effect = exc.HTTPUnauthorized("FAIL")
self.make_env()
args = ['event-list']