openstack/deb-python-dcos
Code Issues Proposed changes

package: sort packages by release version (#859)

Browse Source
This commit is contained in:
José Armando García Sancio
2017-01-04 11:54:13 -08:00
committed by tamarrow
parent 2b2fb3b0d6
commit 24afb2f975
4 changed files with 14 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
cli/tests/data/package/json/test_describe_kafka_package_versions.json Normal file
View File

@@ -0,0 +1,4 @@
[
"0.9.4.0",
"0.9.2.0"
]

3
cli/tests/data/package/json/test_describe_marathon_package_versions.json
View File

@@ -1,3 +0,0 @@
[
"0.11.1"
]

4
cli/tests/integrations/test_package.py
View File

@@ -220,9 +220,9 @@ def test_describe_package_version_missing():
def test_describe_package_versions():
stdout = file_bytes(
'tests/data/package/json/test_describe_marathon_package_versions.json')
'tests/data/package/json/test_describe_kafka_package_versions.json')
assert_command(
['dcos', 'package', 'describe', 'marathon', '--package-versions'],
['dcos', 'package', 'describe', 'kafka', '--package-versions'],
stdout=stdout)

9
dcos/cosmospackage.py
View File

@@ -548,7 +548,14 @@ class CosmosPackageVersion():
response = Cosmos(self._cosmos_url).cosmos_post(
"list-versions", params)
return list(response.json().get("results").keys())
return list(
version for (version, releaseVersion) in
sorted(
response.json().get("results").items(),
key=lambda item: int(item[1]), # release version
reverse=True
)
)
def _get_header(request_type, version):