openstack/deb-python-dcos
Code Issues Proposed changes

util: use stat (not lstat) to check file permissions (#932)

Browse Source 
For symlinks we should look at the permissions of the file
itself rather than the permissions of the symlink.
This commit is contained in:
Marc Abramowitz
2017-03-14 13:16:17 -07:00
committed by tamarrow
parent 7f600c59ca
commit 33efe97f44
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
dcos/util.py
View File

@@ -182,8 +182,10 @@ def enforce_file_permissions(path):
if sys.platform == 'win32':
return
else:
permissions = oct(stat.S_IMODE(os.lstat(path).st_mode))
permissions = oct(stat.S_IMODE(os.stat(path).st_mode))
if permissions not in ['0o600', '0600', '0o400', '0400']:
if os.path.realpath(path) != path:
path = '%s (pointed to by %s)' % (os.path.realpath(path), path)
msg = (
"Permissions '{}' for configuration file '{}' are too open. "
"File must only be accessible by owner. "