openstack/deb-python-dcos
Code Issues Proposed changes

Add package install appid planned deprecation warning (#1013)

Browse Source 
* Added warning message about the planned deprecation for appid
* Fixed broken test cases
* Updated tests adhering to contributing guidelines
This commit is contained in:
Tarun Gupta Akirala
2017-07-17 10:50:54 -07:00
committed by Kevin Klues
parent bdda6756ce
commit c6edbed7ef
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
cli/dcoscli/package/main.py
View File

@@ -367,6 +367,11 @@ def _install(package_name, package_version, options_path, app_id, cli,
emitter.publish(msg)
if app_id is not None:
msg = "Usage of --app-id is deprecated. Use --options instead " \
"and specify a file that contains [service.name] property"
emitter.publish(msg)
package_manager.install_app(pkg, user_options, app_id)
if cli and pkg.cli_definition():

13
cli/tests/integrations/test_package.py
View File

@@ -329,6 +329,8 @@ def test_bad_install_helloworld_msg():
b'A sample pre-installation message\n'
b'Installing Marathon app for package [helloworld] version '
b'[0.1.0] with app id [/foo]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
b'Installing CLI subcommand for package [helloworld] '
b'version [0.1.0]\n'
b'New command available: dcos ' +
@@ -346,6 +348,8 @@ def test_bad_install_helloworld_msg():
b'A sample pre-installation message\n'
b'Installing Marathon app for package [helloworld] version '
b'[0.1.0] with app id [/foo/bar]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
)
stderr = (b'Object is not valid\n'
@@ -491,6 +495,9 @@ def test_install_with_id(zk_znode):
stdout = (
b'Installing Marathon app for package [chronos] version [3.0.1] with '
b'app id [chronos-1]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
)
_install_chronos(args=args, stdout=stdout)
@@ -499,6 +506,8 @@ def test_install_with_id(zk_znode):
stdout = (
b'Installing Marathon app for package [chronos] version [3.0.1] with '
b'app id [chronos-2]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
)
_install_chronos(args=args, stdout=stdout)
@@ -577,6 +586,8 @@ def test_uninstall_multiple_apps():
b'A sample pre-installation message\n'
b'Installing Marathon app for package [helloworld] version '
b'[0.1.0] with app id [/helloworld-1]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
b'A sample post-installation message\n'
)
@@ -590,6 +601,8 @@ def test_uninstall_multiple_apps():
b'A sample pre-installation message\n'
b'Installing Marathon app for package [helloworld] version '
b'[0.1.0] with app id [/helloworld-2]\n'
b'Usage of --app-id is deprecated. Use --options instead and specify '
b'a file that contains [service.name] property\n'
b'A sample post-installation message\n'
)