openstack/deb-python-dcos
Code Issues Proposed changes

fix issue on windows where we move an open file (#742)

Browse Source
This commit is contained in:
tamarrow
2016-08-26 09:37:50 -07:00
committed by José Armando García Sancio
parent d074d73c76
commit d32dacba93
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
dcos/subcommand.py
View File

@@ -493,8 +493,13 @@ def _install_with_binary(
if kind == "executable":
util.ensure_dir_exists(env_bin_dir)
binary_name = "dcos-{}".format(package_name)
if util.is_windows_platform():
binary_name += '.exe'
binary_file = os.path.join(env_bin_dir, binary_name)
shutil.move(binary_tmp, binary_file)
# copy to avoid windows error of moving open file
# binary_tmp will be removed by context manager
shutil.copy(binary_tmp, binary_file)
else:
# kind == "zip"
with zipfile.ZipFile(binary_tmp) as zf: