openstack/deb-python-falcon
Code Issues Proposed changes

fix(test_cookies): Fix references to *httponly* and *secure*

Browse Source 
Starting in Python 3.4.3 the attributes *httponly* and *secure* are
camelcased when serialized. This patch adapts the cookie tests to work
correctly under 3.4.3.

Closes #572
This commit is contained in:
carlgeorge
2015-06-17 14:55:10 -05:00
committed by Kurt Griffiths
parent e4543098a3
commit e10ff51027
2 changed files with 17 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
AUTHORS
View File

@@ -49,3 +49,4 @@ below in order of date of first contribution:
* Christian Pedersen (chripede)
* Harrison Pincket (hpincket)
* Usman Ehtesham Gul (ueg1990)
* Carl George (carlgeorge)

24
tests/test_cookies.py
View File

@@ -1,4 +1,4 @@
import sys
import falcon
import falcon.testing as testing
@@ -54,18 +54,26 @@ class TestCookies(testing.TestBase):
self.resource = CookieResource()
self.api.add_route(self.test_route, self.resource)
self.simulate_request(self.test_route, method="GET")
self.assertIn(
("set-cookie",
"foo=bar; Domain=example.com; httponly; Path=/; secure"),
self.srmock.headers)
if sys.version_info >= (3, 4, 3):
value = "foo=bar; Domain=example.com; HttpOnly; Path=/; Secure"
else:
value = "foo=bar; Domain=example.com; httponly; Path=/; secure"
self.assertIn(("set-cookie", value), self.srmock.headers)
def test_response_complex_case(self):
self.resource = CookieResource()
self.api.add_route(self.test_route, self.resource)
self.simulate_request(self.test_route, method="HEAD")
self.assertIn(("set-cookie", "foo=bar; httponly; Max-Age=300; secure"),
self.srmock.headers)
self.assertIn(("set-cookie", "bar=baz; secure"), self.srmock.headers)
if sys.version_info >= (3, 4, 3):
value = "foo=bar; HttpOnly; Max-Age=300; Secure"
else:
value = "foo=bar; httponly; Max-Age=300; secure"
self.assertIn(("set-cookie", value), self.srmock.headers)
if sys.version_info >= (3, 4, 3):
value = "bar=baz; Secure"
else:
value = "bar=baz; secure"
self.assertIn(("set-cookie", value), self.srmock.headers)
self.assertNotIn(("set-cookie", "bad=cookie"), self.srmock.headers)
def test_cookie_expires_naive(self):