openstack/deb-python-fuelclient
Code Issues Proposed changes

Remove NullHandler

Browse Source 
Remove NullHandler that used to be used for preventing
keystone from logging anything. Using Nullhandler is not
appropriate for python-fuelclient as for library.

Closes-bug: #1592445
Change-Id: Ia77f7dbf32b7c39872dcafef6bac6a25e9fc499d
This commit is contained in:
Roman Prykhodchenko
2016-06-14 16:22:57 +02:00
parent b8daca8431
commit 5c9e2e57f3
2 changed files with 0 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
fuelclient/client.py
View File

@@ -13,7 +13,6 @@
# under the License.
import json
import logging
import requests
from keystoneclient.v2_0 import client as auth_client
@@ -21,13 +20,6 @@ from six.moves.urllib import parse as urlparse
from fuelclient.cli import error
from fuelclient import fuelclient_settings
from fuelclient.logs import NullHandler
# configure logging to silent all logs
# and prevent issues in keystoneclient logging
logger = logging.getLogger()
logger.addHandler(NullHandler())
class APIClient(object):

38
fuelclient/logs.py
View File

@@ -1,38 +0,0 @@
# -*- coding: utf-8 -*-
# Copyright 2014 Mirantis, Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License"); you may
# not use this file except in compliance with the License. You may obtain
# a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
# License for the specific language governing permissions and limitations
# under the License.
import logging
class NullHandler(logging.Handler):
"""This handler does nothing. It's intended to be used to avoid the
"No handlers could be found for logger XXX" one-off warning. This
important for library code, which may contain code to log events.
of the library does not configure logging, the one-off warning mig
produced; to avoid this, the library developer simply needs to ins
a NullHandler and add it to the top-level logger of the library mo
package.
Taken from Python 2.7
"""
def handle(self, record):
pass
def emit(self, record):
pass
def createLock(self):
self.lock = None