openstack/deb-python-glanceclient
Code Issues Proposed changes

Set useful boolean flag metavars

Browse Source 
The boolean flags --is-protected and --is-public now
communicate that they must be set to True or False.

Fixes bug 1056501.

Change-Id: I23094ea556eb71d6eb977a64c171119738ed792b
This commit is contained in:
Brian Waldon
2012-11-19 09:08:39 -08:00
parent 1899ac2963
commit 0e90f8ef23
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
glanceclient/v1/shell.py
View File

@@ -159,9 +159,9 @@ def do_image_download(gc, args):
# to use --is-public
@utils.arg('--public', action='store_true', default=False,
help=argparse.SUPPRESS)
@utils.arg('--is-public', type=utils.string_to_bool,
@utils.arg('--is-public', type=utils.string_to_bool, metavar='[True|False]',
help='Make image accessible to the public.')
@utils.arg('--is-protected', type=utils.string_to_bool,
@utils.arg('--is-protected', type=utils.string_to_bool, metavar='[True|False]',
help='Prevent image from being deleted.')
@utils.arg('--property', metavar="<key=value>", action='append', default=[],
help=("Arbitrary property to associate with image. "
@@ -222,9 +222,9 @@ def do_image_create(gc, args):
help=('Similar to \'--location\' in usage, but this indicates that'
' the Glance server should immediately copy the data and'
' store it in its configured image store.'))
@utils.arg('--is-public', type=utils.string_to_bool,
@utils.arg('--is-public', type=utils.string_to_bool, metavar='[True|False]',
help='Make image accessible to the public.')
@utils.arg('--is-protected', type=utils.string_to_bool,
@utils.arg('--is-protected', type=utils.string_to_bool, metavar='[True|False]',
help='Prevent image from being deleted.')
@utils.arg('--property', metavar="<key=value>", action='append', default=[],
help=("Arbitrary property to associate with image. "