openstack/deb-python-hacking
Code Issues Proposed changes

Add note about checks have community support

Browse Source 
This project is only trying to enforce the agreed upon style guide, not
dictate it.  We do not want a new check added if there is any doubt the
check from the community.  Because this project has very a limited
number of reviewers we have to be extra careful about dictating style to the
rest of the community. Consensus in hacking reviewers is not community
consensus.

Change-Id: Id7aaefb8fb98b365f45c8eeb3aa53de02b9cb4e6
This commit is contained in:
Joe Gordon
2013-06-24 15:02:12 -07:00
parent f2efcacd72
commit ec1f00a07c
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
README.rst
View File

@@ -19,6 +19,7 @@ Each check is a pep8 plugin so read
Requirements
------------
- The check must already have community support. We do not want to dictate style, only enforce it.
- The canonical source of the OpenStack Style Commandments is `HACKING.rst <HACKING.rst>`_, and hacking just enforces them; so when adding a new check, it must be in HACKING.rst
- False negatives are ok, but false positives are not
- Cannot be project specific, project specific checks should be `Local Checks`_