"copy" operation should copy by value, not by reference, fixes #8

This commit is contained in:
Stefan Kögl
2012-09-14 15:22:42 +02:00
parent 3829275ade
commit 46334177e5
2 changed files with 13 additions and 1 deletions

View File

@@ -422,5 +422,5 @@ class CopyOperation(PatchOperation):
def apply(self, obj):
subobj, part = self.locate(obj, self.location)
value = subobj[part]
value = copy.deepcopy(subobj[part])
AddOperation(self.operation['to'], {'value': value}).apply(obj)

View File

@@ -86,6 +86,18 @@ class ApplyPatchTestCase(unittest.TestCase):
self.assertEqual(res, {'foo': ['all', 'grass', 'cows', 'grass', 'eat']})
def test_copy_mutable(self):
""" test if mutable objects (dicts and lists) are copied by value """
obj = {'foo': [{'bar': 42}, {'baz': 3.14}], 'boo': []}
# copy object somewhere
res = jsonpatch.apply_patch(obj, [{'copy': '/foo/0', 'to': '/boo/0' }])
self.assertEqual(res, {'foo': [{'bar': 42}, {'baz': 3.14}], 'boo': [{'bar': 42}]})
# modify original object
res = jsonpatch.apply_patch(res, [{'add': '/foo/0/zoo', 'value': 255}])
# check if that didn't modify the copied object
self.assertEqual(res['boo'], [{'bar': 42}])
def test_test_success(self):
obj = {'baz': 'qux', 'foo': ['a', 2, 'c']}
jsonpatch.apply_patch(obj, [{'test': '/baz', 'value': 'qux'},