openstack/deb-python-kafka
Code Issues Proposed changes

Remove unnecessary method

Browse Source
This commit is contained in:
Omar Ghishan
2014-01-07 17:27:21 -08:00
parent b4c20acf24
commit 20776539f0
1 changed files with 8 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
kafka/conn.py
View File

@@ -61,21 +61,6 @@ class KafkaConnection(local):
return resp
def _consume_response(self):
"""
This method handles the response header and error messages. It
then returns the response
"""
log.debug("Expecting response from Kafka")
# Read the size off of the header
resp = self._read_bytes(4)
(size,) = struct.unpack('>i', resp)
# Read the remainder of the response
resp = self._read_bytes(size)
return str(resp)
##################
# Public API #
##################
@@ -100,8 +85,14 @@ class KafkaConnection(local):
Get a response from Kafka
"""
log.debug("Reading response %d from Kafka" % request_id)
self.data = self._consume_response()
return self.data
# Read the size off of the header
resp = self._read_bytes(4)
(size,) = struct.unpack('>i', resp)
# Read the remainder of the response
resp = self._read_bytes(size)
return str(resp)
def copy(self):
"""