openstack/deb-python-kafka
Code Issues Proposed changes

Mock client.ready() call to test coordinator offset fetch request

Browse Source
This commit is contained in:
Dana Powers
2016-02-18 22:56:05 -08:00
parent 6a2466b4d9
commit 29e96f82ce
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
kafka/coordinator/consumer.py
View File

@@ -563,7 +563,8 @@ class ConsumerCoordinator(BaseCoordinator):
# Verify node is ready
if not self._client.ready(node_id):
log.debug("Node %s not ready -- failing offset fetch request")
log.debug("Node %s not ready -- failing offset fetch request",
node_id)
return Future().failure(Errors.NodeNotReadyError)
log.debug("Fetching committed offsets for partitions: %s", partitions)

1
test/test_coordinator.py
View File

@@ -385,6 +385,7 @@ def patched_coord(mocker, coordinator):
coordinator.coordinator_id = 0
mocker.patch.object(coordinator._client, 'least_loaded_node',
return_value=1)
mocker.patch.object(coordinator._client, 'ready', return_value=True)
mocker.patch.object(coordinator._client, 'send')
mocker.spy(coordinator, '_failed_request')
mocker.spy(coordinator, '_handle_offset_commit_response')