openstack/deb-python-kafka
Code Issues Proposed changes

Initialized _dirty in KafkaConnection __init__() and set _sock to None in close()

Browse Source
This commit is contained in:
Dana Powers
2014-08-17 20:02:47 -07:00
parent fd3927c0d4
commit 45946d872f
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
kafka/conn.py
View File

@@ -55,6 +55,7 @@ class KafkaConnection(local):
self.host = host
self.port = port
self.timeout = timeout
self._dirty = None
self._sock = None
self.reinit()
@@ -75,7 +76,7 @@ class KafkaConnection(local):
responses = []
log.debug("About to read %d bytes from Kafka", num_bytes)
if self._dirty:
if self._dirty or not self._sock:
self.reinit()
while bytes_left:
@@ -105,7 +106,7 @@ class KafkaConnection(local):
"Send a request to Kafka"
log.debug("About to send %d bytes to Kafka, request %d" % (len(payload), request_id))
try:
if self._dirty:
if self._dirty or not self._sock:
self.reinit()
sent = self._sock.sendall(payload)
if sent is not None:
@@ -143,6 +144,7 @@ class KafkaConnection(local):
"""
if self._sock:
self._sock.close()
self._sock = None
def reinit(self):
"""