openstack/deb-python-kafka
Code Issues Proposed changes

DRY-up the OffsetFetch structs (#964)

Browse Source
This commit is contained in:
Jeff Widman
2017-02-03 10:08:12 -08:00
committed by Dana Powers
parent 4c62fb9247
commit ff2a129bc6
1 changed files with 4 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
kafka/protocol/commit.py
View File

@@ -116,20 +116,12 @@ class OffsetFetchResponse_v0(Struct):
class OffsetFetchResponse_v1(Struct):
API_KEY = 9
API_VERSION = 1
SCHEMA = Schema(
('topics', Array(
('topic', String('utf-8')),
('partitions', Array(
('partition', Int32),
('offset', Int64),
('metadata', String('utf-8')),
('error_code', Int16)))))
)
SCHEMA = OffsetFetchResponse_v0.SCHEMA
class OffsetFetchRequest_v0(Struct):
API_KEY = 9
API_VERSION = 0 # zookeeper-backed storage
API_VERSION = 0 # zookeeper-backed storage
RESPONSE_TYPE = OffsetFetchResponse_v0
SCHEMA = Schema(
('consumer_group', String('utf-8')),
@@ -141,14 +133,9 @@ class OffsetFetchRequest_v0(Struct):
class OffsetFetchRequest_v1(Struct):
API_KEY = 9
API_VERSION = 1 # kafka-backed storage
API_VERSION = 1 # kafka-backed storage
RESPONSE_TYPE = OffsetFetchResponse_v1
SCHEMA = Schema(
('consumer_group', String('utf-8')),
('topics', Array(
('topic', String('utf-8')),
('partitions', Array(Int32))))
)
SCHEMA = OffsetFetchRequest_v0.SCHEMA
OffsetFetchRequest = [OffsetFetchRequest_v0, OffsetFetchRequest_v1]