openstack/deb-python-neutronclient
Code Issues Proposed changes

Merge "Router create distributed accepts lower case"

Browse Source
This commit is contained in:
Jenkins
2014-12-15 06:00:46 +00:00
committed by Gerrit Code Review
parent 89271b191e 66612c9de8
commit e069b7d62f
2 changed files with 17 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
neutronclient/neutron/v2_0/router.py
View File

@@ -68,8 +68,8 @@ class CreateRouter(neutronV20.CreateCommand):
help=_('Name of router to create.'))
parser.add_argument(
'--distributed',
dest='distributed',
choices=['True', 'False'],
dest='distributed', metavar='{True,False}',
choices=['True', 'true', 'False', 'false'],
default=argparse.SUPPRESS,
help=_('Create a distributed router.'))
parser.add_argument(

17
neutronclient/tests/unit/test_cli20_router.py
View File

@@ -83,12 +83,25 @@ class CLITestV20RouterJSON(test_cli20.CLITestV20Base):
position_names, position_values,
**expected)
def test_create_router_distributed(self):
self._create_router_distributed_or_ha(distributed=True)
def test_create_router_distributed_True(self):
"""Create router: --distributed=True."""
self._create_router_distributed_or_ha(distributed='True')
def test_create_router_ha(self):
self._create_router_distributed_or_ha(ha=True)
def test_create_router_distributed_False(self):
"""Create router: --distributed=False."""
self._create_router_distributed_or_ha(distributed='False')
def test_create_router_distributed_true(self):
"""Create router: --distributed=true."""
self._create_router_distributed_or_ha(distributed='true')
def test_create_router_distributed_false(self):
"""Create router: --distributed=false."""
self._create_router_distributed_or_ha(distributed='false')
def test_list_routers_detail(self):
"""list routers: -D."""
resources = "routers"