openstack/deb-python-oauth2client
Code Issues Proposed changes

Changing prn (for service account assertions) to sub, per specification change.

Browse Source 
Reviewed in https://codereview.appspot.com/7791043/
This commit is contained in:
Daniel Hermes
2013-03-13 13:37:27 -07:00
parent 14eb973791
commit 482ab7679e
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
oauth2client/client.py
View File

@@ -925,7 +925,7 @@ if HAS_CRYPTO:
defaults to Google's endpoints but any OAuth 2.0 provider can be used.
revoke_uri: string, URI for revoke endpoint.
kwargs: kwargs, Additional parameters to add to the JWT token, for
example prn=joe@xample.org."""
example sub=joe@xample.org."""
super(SignedJwtAssertionCredentials, self).__init__(
None,

10
tests/test_oauth2client_jwt.py
View File

@@ -217,7 +217,7 @@ class SignedJwtAssertionCredentialsTests(unittest.TestCase):
'some_account@example.com',
private_key,
scope='read+write',
prn='joe@example.org')
sub='joe@example.org')
http = HttpMockSequence([
({'status': '200'}, '{"access_token":"1/3w","expires_in":3600}'),
({'status': '200'}, 'echo_request_headers'),
@@ -232,7 +232,7 @@ class SignedJwtAssertionCredentialsTests(unittest.TestCase):
'some_account@example.com',
private_key,
scope='read+write',
prn='joe@example.org')
sub='joe@example.org')
json = credentials.to_json()
restored = Credentials.new_from_json(json)
self.assertEqual(credentials.private_key, restored.private_key)
@@ -257,7 +257,7 @@ class SignedJwtAssertionCredentialsTests(unittest.TestCase):
'some_account@example.com',
private_key,
scope='read+write',
prn='joe@example.org')
sub='joe@example.org')
content = self._credentials_refresh(credentials)
@@ -269,7 +269,7 @@ class SignedJwtAssertionCredentialsTests(unittest.TestCase):
'some_account@example.com',
private_key,
scope='read+write',
prn='joe@example.org')
sub='joe@example.org')
(filehandle, filename) = tempfile.mkstemp()
os.close(filehandle)
@@ -305,7 +305,7 @@ class PKCSSignedJwtAssertionCredentialsPyCryptoTests(unittest.TestCase):
'some_account@example.com',
private_key,
scope='read+write',
prn='joe@example.org')
sub='joe@example.org')
try:
credentials._generate_assertion()
self.fail()