Remove unused local variable assignment

Fixed flake8 F841 errors: local variable is assigned to but never used.
This commit is contained in:
Pat Ferate
2016-07-07 14:11:02 -07:00
parent c8640c0d72
commit 514c170746
5 changed files with 19 additions and 31 deletions

View File

@@ -178,4 +178,4 @@ class Storage(BaseStorage):
"""Delete Credentials from the datastore."""
query = {self.key_name: self.key_value}
entities = self.model_class.objects.filter(**query).delete()
self.model_class.objects.filter(**query).delete()

View File

@@ -847,7 +847,7 @@ class DecoratorTests(unittest2.TestCase):
# An initial request to an oauth_aware decorated path should
# not redirect.
response = self.app.get('/bar_path/2012/01')
url = self.decorator.authorize_url()
self.decorator.authorize_url()
response = self.app.get('/oauth2callback', {
'error': 'Bad<Stuff>Happened\''
})
@@ -903,9 +903,7 @@ class DecoratorTests(unittest2.TestCase):
with decorator_patch as decorator_mock:
filename = datafile('client_secrets.json')
decorator = oauth2decorator_from_clientsecrets(
filename,
scope='foo_scope')
oauth2decorator_from_clientsecrets(filename, scope='foo_scope')
decorator_mock.assert_called_once_with(
filename,
'foo_scope',
@@ -974,7 +972,7 @@ class DecoratorTests(unittest2.TestCase):
def test_decorator_from_unfilled_client_secrets_required(self):
MESSAGE = 'File is missing'
try:
decorator = OAuth2DecoratorFromClientSecrets(
OAuth2DecoratorFromClientSecrets(
datafile('unfilled_client_secrets.json'),
scope=['foo_scope', 'bar_scope'], message=MESSAGE)
except InvalidClientSecretsError:
@@ -983,7 +981,7 @@ class DecoratorTests(unittest2.TestCase):
def test_decorator_from_unfilled_client_secrets_aware(self):
MESSAGE = 'File is missing'
try:
decorator = OAuth2DecoratorFromClientSecrets(
OAuth2DecoratorFromClientSecrets(
datafile('unfilled_client_secrets.json'),
scope=['foo_scope', 'bar_scope'], message=MESSAGE)
except InvalidClientSecretsError:

View File

@@ -49,7 +49,6 @@ class Test_generate_token(unittest2.TestCase):
def test_it(self):
digest = b'foobar'
curr_time = 1440449755.74
digester = mock.MagicMock()
digester.digest = mock.MagicMock(name='digest', return_value=digest)
with mock.patch('oauth2client.contrib.xsrfutil.hmac') as hmac:

View File

@@ -124,7 +124,7 @@ class CredentialsTests(unittest2.TestCase):
def test_to_from_json(self):
credentials = Credentials()
json = credentials.to_json()
restored = Credentials.new_from_json(json)
Credentials.new_from_json(json)
def test_authorize_abstract(self):
credentials = Credentials()
@@ -1863,8 +1863,7 @@ class OAuth2WebServerFlowTest(unittest2.TestCase):
])
with self.assertRaises(FlowExchangeError):
credentials = self.flow.step2_exchange(code='some random code',
http=http)
self.flow.step2_exchange(code='some random code', http=http)
def test_urlencoded_exchange_failure(self):
http = HttpMockSequence([
@@ -1873,8 +1872,7 @@ class OAuth2WebServerFlowTest(unittest2.TestCase):
with self.assertRaisesRegexp(FlowExchangeError,
'invalid_request'):
credentials = self.flow.step2_exchange(code='some random code',
http=http)
self.flow.step2_exchange(code='some random code', http=http)
def test_exchange_failure_with_json_error(self):
# Some providers have 'error' attribute as a JSON object
@@ -1890,8 +1888,7 @@ class OAuth2WebServerFlowTest(unittest2.TestCase):
http = HttpMockSequence([({'status': '400'}, payload)])
with self.assertRaises(FlowExchangeError):
credentials = self.flow.step2_exchange(code='some random code',
http=http)
self.flow.step2_exchange(code='some random code', http=http)
def _exchange_success_test_helper(self, code=None, device_flow_info=None):
payload = (b'{'
@@ -2040,9 +2037,8 @@ class OAuth2WebServerFlowTest(unittest2.TestCase):
http = HttpMockSequence([({'status': '200'}, payload)])
code = {'error': 'thou shall not pass'}
with self.assertRaisesRegexp(FlowExchangeError,
'shall not pass'):
credentials = self.flow.step2_exchange(code=code, http=http)
with self.assertRaisesRegexp(FlowExchangeError, 'shall not pass'):
self.flow.step2_exchange(code=code, http=http)
def test_exchange_id_token_fail(self):
payload = (b'{'
@@ -2190,9 +2186,8 @@ class CredentialsFromCodeTests(unittest2.TestCase):
({'status': '200'}, payload.encode('utf-8')),
])
credentials = credentials_from_code(self.client_id, self.client_secret,
self.scope, self.code,
redirect_uri=self.redirect_uri,
http=http)
self.scope, self.code, http=http,
redirect_uri=self.redirect_uri)
self.assertEqual(credentials.access_token, token)
self.assertNotEqual(None, credentials.token_expiry)
self.assertEqual(set(['foo']), credentials.scopes)
@@ -2203,11 +2198,9 @@ class CredentialsFromCodeTests(unittest2.TestCase):
])
with self.assertRaises(FlowExchangeError):
credentials = credentials_from_code(self.client_id,
self.client_secret,
self.scope, self.code,
redirect_uri=self.redirect_uri,
http=http)
credentials_from_code(self.client_id, self.client_secret,
self.scope, self.code, http=http,
redirect_uri=self.redirect_uri)
def test_exchange_code_and_file_for_token(self):
payload = (b'{'
@@ -2241,7 +2234,7 @@ class CredentialsFromCodeTests(unittest2.TestCase):
])
with self.assertRaises(FlowExchangeError):
credentials = credentials_from_clientsecrets_and_code(
credentials_from_clientsecrets_and_code(
datafile('client_secrets.json'), self.scope,
self.code, http=http)

View File

@@ -149,8 +149,7 @@ class TestRunFlow(unittest2.TestCase):
# Exchange returned an error code.
with self.assertRaises(SystemExit):
returned_credentials = tools.run_flow(
self.flow, self.storage, flags=self.server_flags)
tools.run_flow(self.flow, self.storage, flags=self.server_flags)
self.assertTrue(self.server.handle_request.called)
@@ -164,8 +163,7 @@ class TestRunFlow(unittest2.TestCase):
# No code found in response
with self.assertRaises(SystemExit):
returned_credentials = tools.run_flow(
self.flow, self.storage, flags=self.server_flags)
tools.run_flow(self.flow, self.storage, flags=self.server_flags)
self.assertTrue(self.server.handle_request.called)