openstack/deb-python-oauth2client
Code Issues Proposed changes

Added 'state' parameter to step1_get_authorize_url.

Browse Source
This commit is contained in:
Frederik Creemers
2015-07-10 20:38:10 +02:00
parent ea9b8c4ebd
commit 60fd97608e
2 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
oauth2client/client.py
View File

@@ -1849,7 +1849,7 @@ class OAuth2WebServerFlow(Flow):
self.params.update(kwargs)
@util.positional(1)
def step1_get_authorize_url(self, redirect_uri=None):
def step1_get_authorize_url(self, redirect_uri=None, state=None):
"""Returns a URI to redirect to the provider.
Args:
@@ -1876,6 +1876,8 @@ class OAuth2WebServerFlow(Flow):
'redirect_uri': self.redirect_uri,
'scope': self.scope,
}
if state is not None:
query_params['state'] = state
if self.login_hint is not None:
query_params['login_hint'] = self.login_hint
query_params.update(self.params)

3
tests/test_oauth2client.py
View File

@@ -981,7 +981,7 @@ class OAuth2WebServerFlowTest(unittest.TestCase):
)
def test_construct_authorize_url(self):
authorize_url = self.flow.step1_get_authorize_url()
authorize_url = self.flow.step1_get_authorize_url(state='state+1')
parsed = urllib.parse.urlparse(authorize_url)
q = urllib.parse.parse_qs(parsed[4])
@@ -990,6 +990,7 @@ class OAuth2WebServerFlowTest(unittest.TestCase):
self.assertEqual('foo', q['scope'][0])
self.assertEqual(OOB_CALLBACK_URN, q['redirect_uri'][0])
self.assertEqual('offline', q['access_type'][0])
self.assertEqual('state+1', q['state'][0])
def test_override_flow_via_kwargs(self):
"""Passing kwargs to override defaults."""