openstack/deb-python-oauth2client
Code Issues Proposed changes

Expand API for step2_exchange

Browse Source 
In python 3, the code received from the browser will be binary instead of a string. Expand the API for oauth_flow.step2_exchange(code) to allow this value to be passed as is rather than decoding.

for example:
credentials = self.flow.step2_exchange(b'some random code')

test:
tox -e py34  -- tests.test_client:OAuth2WebServerFlowTest.test_exchange_success_binary_code

resolves:  #443, #446
This commit is contained in:
Eddie Warner
2016-03-01 12:05:18 -08:00
parent 4b0a5edd47
commit 6a273d678b
2 changed files with 22 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
oauth2client/client.py
View File

@@ -2069,7 +2069,7 @@ class OAuth2WebServerFlow(Flow):
if code is None:
code = device_flow_info.device_code
elif not isinstance(code, six.string_types):
elif not isinstance(code, (six.string_types, six.binary_type)):
if 'code' not in code:
raise FlowExchangeError(code.get(
'error', 'No code was supplied in the query parameters.'))

21
tests/test_client.py
View File

@@ -79,6 +79,7 @@ from oauth2client.client import flow_from_clientsecrets
from oauth2client.client import save_to_well_known_file
from oauth2client.clientsecrets import _loadfile
from oauth2client.service_account import ServiceAccountCredentials
from oauth2client._helpers import _to_bytes
__author__ = 'jcgregorio@google.com (Joe Gregorio)'
@@ -1201,6 +1202,26 @@ class OAuth2WebServerFlowTest(unittest2.TestCase):
self.assertEqual('dummy_revoke_uri', credentials.revoke_uri)
self.assertEqual(set(['foo']), credentials.scopes)
def test_exchange_success_binary_code(self):
binary_code = b'some random code'
access_token = 'SlAV32hkKG'
expires_in = '3600'
refresh_token = '8xLOxBtZp8'
revoke_uri = 'dummy_revoke_uri'
payload = ('{'
' "access_token":"' + access_token + '",'
' "expires_in":' + expires_in + ','
' "refresh_token":"' + refresh_token + '"'
'}')
http = HttpMockSequence([({'status': '200'}, _to_bytes(payload))])
credentials = self.flow.step2_exchange(binary_code, http=http)
self.assertEqual(access_token, credentials.access_token)
self.assertIsNotNone(credentials.token_expiry)
self.assertEqual(refresh_token, credentials.refresh_token)
self.assertEqual(revoke_uri, credentials.revoke_uri)
self.assertEqual(set(['foo']), credentials.scopes)
def test_exchange_dictlike(self):
class FakeDict(object):
def __init__(self, d):