openstack/deb-python-openstackclient
Code Issues Proposed changes

Update notes for submitted changes

Browse Source 
* Updated from global requirements
* Fix "volume unset" command pass normally when nothing specified
* Use correct router add/remove interface methods
* Refactor volume unit test with FakeVolume class in volume v1
* replace metavar "volume-id" with "volume" to avoid ambiguity
* Remove unnecessary setUp
This commit is contained in:
Gerrit Code Review
2016-09-22 07:20:00 +00:00
parent c53d242f9f
commit 466a2be327
6 changed files with 54 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
27/4e400f5a033da073a8a790eb4895fe7faced86 Normal file
View File

@@ -0,0 +1,8 @@
Code-Review+2: Richard Theis <rtheis@us.ibm.com>
Workflow+1: Richard Theis <rtheis@us.ibm.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 21 Sep 2016 14:36:56 +0000
Reviewed-on: https://review.openstack.org/373716
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master

10
47/b782687f4c23d03e872fb2b2b69b57ba3f9aec Normal file
View File

@@ -0,0 +1,10 @@
Code-Review+2: Tang Chen <chen.tang@easystack.cn>
Code-Review+1: Huanxuan Ao <huanxuan.ao@easystack.cn>
Code-Review+2: Richard Theis <rtheis@us.ibm.com>
Workflow+1: Richard Theis <rtheis@us.ibm.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 21 Sep 2016 15:49:22 +0000
Reviewed-on: https://review.openstack.org/373823
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master

9
4a/8b802d6b1b4de4979260234b0fda4b18a01699 Normal file
View File

@@ -0,0 +1,9 @@
Code-Review+2: Steve Martinelli <s.martinelli@gmail.com>
Code-Review+2: Tang Chen <chen.tang@easystack.cn>
Workflow+1: Tang Chen <chen.tang@easystack.cn>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 22 Sep 2016 02:33:59 +0000
Reviewed-on: https://review.openstack.org/373732
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master

9
6f/0462732a999f43ca0a602e1f323c833debaa5c Normal file
View File

@@ -0,0 +1,9 @@
Code-Review+2: Steve Martinelli <s.martinelli@gmail.com>
Code-Review+2: Tang Chen <chen.tang@easystack.cn>
Workflow+1: Tang Chen <chen.tang@easystack.cn>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 21 Sep 2016 04:30:29 +0000
Reviewed-on: https://review.openstack.org/373597
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master

9
b3/0a7b795f346e7ccc5575602550ca430bfb71a0 Normal file
View File

@@ -0,0 +1,9 @@
Code-Review+2: Steve Martinelli <s.martinelli@gmail.com>
Code-Review+2: Tang Chen <chen.tang@easystack.cn>
Workflow+1: Tang Chen <chen.tang@easystack.cn>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Wed, 21 Sep 2016 07:48:45 +0000
Reviewed-on: https://review.openstack.org/373641
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master

9
bb/a5c9047f81439a18e4e8be434f51abab83a24a Normal file
View File

@@ -0,0 +1,9 @@
Code-Review+2: Steve Martinelli <s.martinelli@gmail.com>
Code-Review+2: Dean Troyer <dtroyer@gmail.com>
Workflow+1: Dean Troyer <dtroyer@gmail.com>
Verified+2: Jenkins
Submitted-by: Jenkins
Submitted-at: Thu, 22 Sep 2016 02:35:13 +0000
Reviewed-on: https://review.openstack.org/373836
Project: openstack/deb-python-openstackclient
Branch: refs/heads/master