rpc, notifier: remove deprecated modules

Let's remove that altogether now that everybody migrated to oslo.messaging.

Change-Id: I7ac0dba821601c5d6cb61b40951c9692782d88be

openstack/common/service.py

@@ -39,13 +39,11 @@ from oslo.config import cfg
 
 from openstack.common import eventlet_backdoor
 from openstack.common.gettextutils import _LE, _LI, _LW
-from openstack.common import importutils
 from openstack.common import log as logging
 from openstack.common import systemd
 from openstack.common import threadgroup
 
 
-rpc = importutils.try_import('openstack.common.rpc')
 CONF = cfg.CONF
 LOG = logging.getLogger(__name__)
 
@@ -180,12 +178,6 @@ class ServiceLauncher(Launcher):
             status = exc.code
         finally:
             self.stop()
-            if rpc:
-                try:
-                    rpc.cleanup()
-                except Exception:
-                    # We're shutting down, so it doesn't matter at this point.
-                    LOG.exception(_LE('Exception during rpc cleanup.'))
 
         return status, signo
 

tests/unit/test_service.py

@@ -38,7 +38,6 @@ from six.moves import mox
 from openstack.common import eventlet_backdoor
 from openstack.common.fixture import config
 from openstack.common import log as logging
-from openstack.common.notifier import api as notifier_api
 from openstack.common import service
 
 
@@ -81,12 +80,9 @@ class ServiceTestBase(test_base.BaseTestCase):
     def setUp(self):
         super(ServiceTestBase, self).setUp()
         self.CONF = self.useFixture(config.Config()).conf
-        # FIXME(markmc): Ugly hack to workaround bug #1073732
-        self.CONF.unregister_opts(notifier_api.notifier_opts)
         # NOTE(markmc): ConfigOpts.log_opt_values() uses CONF.config-file
         self.CONF(args=[], default_config_files=[])
         self.addCleanup(self.CONF.reset)
-        self.addCleanup(self.CONF.register_opts, notifier_api.notifier_opts)
         self.addCleanup(self._reap_pid)
 
     def _reap_pid(self):