openstack/deb-python-osprofiler
Code Issues Proposed changes

Add exception to trace point details

Browse Source 
Adding exception raised by the method to its corresponding
trace point details.

Change-Id: I8bdaee1f4eaf8cd7875c5264519e03f2d04ea12a
This commit is contained in:
Vipin Balachandran
2016-11-18 14:05:48 +05:30
parent 7f8dfd65d2
commit 3de2aec777
5 changed files with 17 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
osprofiler/cmd/template.html
View File

@@ -145,7 +145,7 @@
var trace_data = "<div class='row'>"
columns = ["name", "project", "service", "host", "started",
"finished", "duration", "metadata"];
"finished", "duration", "exception", "metadata"];
for (var i = 0; i < columns.length; i++){
trace_data += "<div class='col-md-2 text-right text-capitalize'><strong>" + columns[i] + " </strong></div>";
trace_data += "<div class='col-md-10 text-left'>" + info[columns[i]] + "</div>";

4
osprofiler/drivers/base.py
View File

@@ -175,6 +175,10 @@ class Driver(object):
if name.endswith("stop"):
self.result[trace_id]["info"]["finished"] = timestamp
self.result[trace_id]["info"]["exception"] = "None"
if raw_payload and "info" in raw_payload:
exc = raw_payload["info"].get("etype", "None")
self.result[trace_id]["info"]["exception"] = exc
else:
self.result[trace_id]["info"]["started"] = timestamp

6
osprofiler/tests/drivers/test_ceilometer.py
View File

@@ -376,7 +376,8 @@ class CeilometerParserTestCase(test.TestCase):
"name": "db",
"project": "keystone",
"service": "main",
"started": 56},
"started": 56,
"exception": "None"},
"parent_id": "06320327-2c2c-45ae-923a-515de890276a",
"trace_id": "1baf1d24-9ca9-4f4c-bd3f-01b7e0c0735a"}
],
@@ -397,7 +398,8 @@ class CeilometerParserTestCase(test.TestCase):
"name": "wsgi",
"project": "keystone",
"service": "main",
"started": 88},
"started": 88,
"exception": "None"},
"parent_id": "7253ca8c-33b3-4f84-b4f1-f5a4311ddfa4",
"trace_id": "016c97fd-87f3-40b2-9b55-e431156b694b"}],
"info": {"finished": 88, "name": "total", "started": 0},

6
osprofiler/tests/drivers/test_mongodb.py
View File

@@ -223,7 +223,8 @@ class MongoDBParserTestCase(test.TestCase):
"name": "db",
"project": "keystone",
"service": "main",
"started": 56},
"started": 56,
"exception": "None"},
"parent_id": "06320327-2c2c-45ae-923a-515de890276a",
"trace_id": "1baf1d24-9ca9-4f4c-bd3f-01b7e0c0735a"}],
@@ -269,7 +270,8 @@ class MongoDBParserTestCase(test.TestCase):
"name": "wsgi",
"project": "keystone",
"service": "main",
"started": 41},
"started": 41,
"exception": "None"},
"parent_id": "7253ca8c-33b3-4f84-b4f1-f5a4311ddfa4",
"trace_id": "839ca3f1-afcb-45be-a4a1-679124c552bf"},

6
osprofiler/tests/drivers/test_redis_driver.py
View File

@@ -228,7 +228,8 @@ class RedisParserTestCase(test.TestCase):
"name": "db",
"project": "keystone",
"service": "main",
"started": 56},
"started": 56,
"exception": "None"},
"parent_id": "06320327-2c2c-45ae-923a-515de890276a",
"trace_id": "1baf1d24-9ca9-4f4c-bd3f-01b7e0c0735a"}],
@@ -274,7 +275,8 @@ class RedisParserTestCase(test.TestCase):
"name": "wsgi",
"project": "keystone",
"service": "main",
"started": 41},
"started": 41,
"exception": "None"},
"parent_id": "7253ca8c-33b3-4f84-b4f1-f5a4311ddfa4",
"trace_id": "839ca3f1-afcb-45be-a4a1-679124c552bf"},