openstack/deb-python-pygit2
Code Issues Proposed changes

Don't leave dangling references to oid strings

Browse Source
This commit is contained in:
richo
2013-01-04 23:03:03 +11:00
parent b65244282e
commit 63d319895c
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/pygit2/repository.c
View File

@@ -165,12 +165,14 @@ static int
Repository_build_as_iter(git_oid *oid, PyObject *accum) Repository_build_as_iter(git_oid *oid, PyObject *accum)
{ {
int err; int err;
PyObject *oid_str = git_oid_to_py_str(oid);
err = PyList_Append(accum, git_oid_to_py_str(oid)); err = PyList_Append(accum, oid_str);
if (err < 0) { if (err < 0) {
Error_set(err); Error_set(err);
return -1; return -1;
} }
Py_XDECREF(oid_str);
return 0; return 0;
} }