openstack/deb-python-pygit2
Code Issues Proposed changes

Use libgit2 LIBGIT2_VER* constants directly instead of git_libgit2_version() call.

Browse Source
This commit is contained in:
Christian Boos 2013-02-17 12:52:36 +01:00
parent 8f843beecf
commit 64ae9e19f4
2 changed files with 5 additions and 8 deletions

3
pygit2/__init__.py

@ -29,5 +29,4 @@ from .version import __version__
from _pygit2 import *
import pygit2.utils
__libgit2_version__ = '%d.%d.%s' % (
LIBGIT2_VERSION_MAJOR, LIBGIT2_VERSION_MINOR, LIBGIT2_VERSION_REV)
__libgit2_version__ = LIBGIT2_VERSION

10
src/pygit2.c

@ -179,8 +179,6 @@ PyMethodDef module_methods[] = {
PyObject*
moduleinit(PyObject* m)
{
int libgit2_major, libgit2_minor, libgit2_rev;
if (m == NULL)
return NULL;
@ -404,10 +402,10 @@ moduleinit(PyObject* m)
PyModule_AddIntConstant(m, "GIT_FILEMODE_COMMIT", GIT_FILEMODE_COMMIT);
/* libgit2 version info */
git_libgit2_version(&libgit2_major, &libgit2_minor, &libgit2_rev);
PyModule_AddIntConstant(m, "LIBGIT2_VERSION_MAJOR", libgit2_major);
PyModule_AddIntConstant(m, "LIBGIT2_VERSION_MINOR", libgit2_minor);
PyModule_AddIntConstant(m, "LIBGIT2_VERSION_REV", libgit2_rev);
PyModule_AddIntConstant(m, "LIBGIT2_VER_MAJOR", LIBGIT2_VER_MAJOR);
PyModule_AddIntConstant(m, "LIBGIT2_VER_MINOR", LIBGIT2_VER_MINOR);
PyModule_AddIntConstant(m, "LIBGIT2_VER_REVISION", LIBGIT2_VER_REVISION);
PyModule_AddStringConstant(m, "LIBGIT2_VERSION", LIBGIT2_VERSION);
return m;
}