openstack/deb-python-pygit2
Code Issues Proposed changes

Fix double free in case of initializing a TreeBuilder with Tree

Browse Source 
object.
This commit is contained in:
Han-Wen Nienhuys
2012-04-30 15:45:02 -03:00
parent cad9b89919
commit 6caf65915d
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
pygit2.c
View File

@@ -1000,6 +1000,7 @@ Repository_TreeBuilder(Repository *self, PyObject *args)
PyObject *py_src = NULL;
git_oid oid;
git_tree *tree = NULL;
git_tree *must_free = NULL;
int err;
if (!PyArg_ParseTuple(args, "|O", &py_src))
@@ -1020,11 +1021,15 @@ Repository_TreeBuilder(Repository *self, PyObject *args)
err = git_tree_lookup(&tree, self->repo, &oid);
if (err < 0)
return Error_set(err);
must_free = tree;
}
}
err = git_treebuilder_create(&bld, tree);
git_tree_free(tree);
if (must_free != NULL) {
git_tree_free(must_free);
}
if (err < 0)
return Error_set(err);