openstack/deb-python-pygit2
Code Issues Proposed changes

Make Repostirory_as_iter shorter

Browse Source 
Error_set already returns NULL
This commit is contained in:
J. David Ibáñez
2013-01-05 10:36:09 +01:00
parent 48b906cf2c
commit 9ec56c07ea
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/pygit2/repository.c
View File

@@ -180,21 +180,17 @@ Repository_as_iter(Repository *self)
PyObject *accum = PyList_New(0); PyObject *accum = PyList_New(0);
err = git_repository_odb(&odb, self->repo); err = git_repository_odb(&odb, self->repo);
if (err < 0) { if (err < 0)
Error_set(err); return Error_set(err);
return NULL;
}
err = git_odb_foreach(odb, Repository_build_as_iter, (void*)accum); err = git_odb_foreach(odb, Repository_build_as_iter, (void*)accum);
if (err == GIT_EUSER) {
git_odb_free(odb); git_odb_free(odb);
if (err == GIT_EUSER) {
return NULL; return NULL;
} else if (err < 0) { } else if (err < 0) {
git_odb_free(odb); return Error_set(err);
Error_set(err);
return NULL;
} }
git_odb_free(odb);
return PyObject_GetIter(accum); return PyObject_GetIter(accum);
} }