openstack/deb-python-requestbuilder
Code Issues Proposed changes

Log backtraces before eating them

Browse Source
This commit is contained in:
Garrett Holmstrom
2013-08-03 00:42:29 +00:00
parent 6b2ca7994e
commit 0269506f1e
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
requestbuilder/service.py
View File

@@ -234,6 +234,7 @@ class BaseService(object):
self.handle_http_error(response)
return response
except requests.exceptions.ConnectionError as exc:
self.log.debug('connection error', exc_info=True)
if len(exc.args) > 0 and hasattr(exc.args[0], 'reason'):
raise ClientError(exc.args[0].reason)
else:
@@ -241,9 +242,11 @@ class BaseService(object):
except requests.exceptions.HTTPError as exc:
return self.handle_http_error(response)
except requests.exceptions.RequestException as exc:
self.log.debug('request error', exc_info=True)
raise ClientError(exc)
def handle_http_error(self, response):
self.log.debug('HTTP error', exc_info=True)
raise ServerError(response)
def __log_and_send_request(self, method, url, params, data, headers):